GNOME Bugzilla – Bug 606635
Libvisual Parameters not supported
Last modified: 2018-11-03 11:16:10 UTC
It would be nice if the libvisual-plugin could support setting VisParams through gStreamer as in http://libvisual.svn.sourceforge.net/viewvc/libvisual/trunk/libvisual/lv_param.h Without it, all libvisual actors are usable with their default settings only :( It should be pretty trivial to support the most important parameter-types: * VISUAL_PARAM_ENTRY_TYPE_STRING * VISUAL_PARAM_ENTRY_TYPE_INTEGER * VISUAL_PARAM_ENTRY_TYPE_FLOAT * VISUAL_PARAM_ENTRY_TYPE_DOUBLE * VISUAL_PARAM_ENTRY_TYPE_COLOR you might want to visit #libvisual on freenode for questions
Created attachment 151373 [details] [review] This enables the libvisual plugin to get/set libvisual parameters.
I should have noted that since libvisual lacks annotations and such, it's impossible to include help text and property defaults. We're waiting to talk with libvisual's maintainer on a new release to include some additional features such as these.
Created attachment 151379 [details] [review] This update allows dynamic property changes. In the above patch only initial property settings would make it through. This patch fixes that.
Comment on attachment 151379 [details] [review] This update allows dynamic property changes. This patch seems to be reverted. Could you attach it again correctly? :) Also, any news about adding some more information to libvisual's parameters?
Created attachment 151690 [details] [review] This fixes the reverted patch.
Sebastian, there's some work on libvisual's svn. Annotations are in at the moment, plus defaults and min/max, so basically everything to satisfy gstreamer.
Comment on attachment 151690 [details] [review] This fixes the reverted patch. Please update the patch to use the libvisual annotations for properties. Without it's not very useful imho
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/28.