GNOME Bugzilla – Bug 606418
ALT+F2 doesnt'work in PATH is misconfigured
Last modified: 2010-01-14 18:18:46 UTC
I have the env variable PATH misconfigured: PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin but /usr/local/bin doesn't exist. When I toggle Alt+F2 to start runDialog it fails with this message: JS ERROR: !!! Exception was: Error: Error invoking Gio.query_info: Errore nell'eseguire lo stat del file "/usr/local/bin": No such file or directory JS ERROR: !!! lineNumber = '0' JS ERROR: !!! fileName = 'gjs_throw' JS ERROR: !!! message = 'Error invoking Gio.query_info: Errore nell'eseguire lo stat del file "/usr/local/bin": No such file or directory' JS ERROR: !!! stack = 'Error("Error invoking Gio.query_info: Errore nell'eseguire lo stat del file \"/usr/local/bin\": No such file or directory")@:0 ("Error invoking Gio.query_info: Errore nell'eseguire lo stat del file \"/usr/local/bin\": No such file or directory")@gjs_throw:0 @:0 ()@/usr/share/gnome-shell/js/ui/runDialog.js:45 CommandCompleter()@/usr/share/gnome-shell/js/ui/runDialog.js:31 ()@/usr/share/gnome-shell/js/ui/runDialog.js:280 RunDialog()@/usr/share/gnome-shell/js/ui/runDialog.js:168 getRunDialog()@/usr/share/gnome-shell/js/ui/main.js:367 ([object _private_Shell_WM],"panel_run_dialog",null,false)@/usr/share/gnome-shell/js/ui/main.js:107 Error("Chained exception")@:0 ("Chained exception")@gjs_throw:0 and nothing appear.
Created attachment 151035 [details] [review] Patch to fix the problem of env var PATH Consider the following patch for inclusion to fix the problem
Created attachment 151042 [details] [review] Fix crash in runDialog I am afraid your patch does not enough to fix the problem - if I recall correctly, it will fail later when setting up file monitors for non-existing paths. This patch was originally filed on bug 604958, I just added a proper commit message. Credit goes entirely to Maxim.
Review of attachment 151042 [details] [review]: ::: js/ui/runDialog.js @@ +47,3 @@ + info = file.query_info(Gio.FILE_ATTRIBUTE_STANDARD_TYPE, Gio.FileQueryInfoFlags.NONE, null); + try { + let info; We should flag these catchalls in the code somehow so when we later add support for error domain+code to gjs we'll be able to fix them. // FIXME catchall Or something like that?
Created attachment 151044 [details] [review] Fix crash in runDialog OK, added the comment as requested.
Attachment 151044 [details] pushed as 2a0e0ae - Fix crash in runDialog