Bug 606340 – Crash on non-utf8 letter in mail folder name

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 606340 - Crash on non-utf8 letter in mail folder name


Summary:	Crash on non-utf8 letter in mail folder name


Status:	RESOLVED FIXED

Product:	evolution
Classification:	Applications
Component:	general
Version:	2.28.x (obsolete)
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Evolution Shell Maintainers Team
QA Contact:	Evolution QA team

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2010-01-07 19:26 UTC by Milan Crha
Modified:	2010-01-08 15:32 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
evo patch 2.28 (1.43 KB, patch) 2010-01-07 20:01 UTC, Milan Crha	committed	Details \| Review

Description Milan Crha 2010-01-07 19:26:45 UTC

moving this from downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=547138

Attached file: backtrace
cmdline: evolution --component=mail
component: evolution
executable: /usr/bin/evolution
kernel: 2.6.31.6-166.fc12.x86_64
package: evolution-2.28.0-2.fc12
rating: 3
reason: Process was terminated by signal 11 (Segmentation fault)  

I imported my outlook pst-file and one of the folders contained the norwegian
character å. The character is not imported correctly, so evolution closes when
this folder is shown.

+ Trace 219954

Thread 1 (Thread 10775)

#0 g_markup_escape_text
from /lib64/libglib-2.0.so.0
#1 g_markup_vprintf_escaped
from /lib64/libglib-2.0.so.0
#2 g_markup_printf_escaped
from /lib64/libglib-2.0.so.0
#3 e_info_label_set_info
at e-info-label.c line 238
#4 view_changed
at mail-component.c line 612
#5 view_changed_timeout
at mail-component.c line 651
#6 ??
from /lib64/libglib-2.0.so.0
#7 g_main_context_dispatch
from /lib64/libglib-2.0.so.0
#8 ??
from /lib64/libglib-2.0.so.0
#9 g_main_loop_run
from /lib64/libglib-2.0.so.0
#10 bonobo_main
at bonobo-main.c line 311
#11 main
at main.c line 732

Comment 1 Milan Crha 2010-01-07 19:45:53 UTC

I created a test pst file with some special letters and it had been imported properly in evolution 2.28.2, folder name was encoded to utf8 as expected. Thus I will only sanitize input to prevent this crash.

Comment 2 Milan Crha 2010-01-07 20:01:43 UTC

Created attachment 150993 [details] [review]
evo patch 2.28

for evolution 2.28;

This should make it for stable. How is it done for master?

Comment 3 Milan Crha 2010-01-07 20:04:22 UTC

Created commit 4aae323 in evo gnome-2-28 (2.28.3+)

Comment 4 Matthew Barnes 2010-01-07 23:12:19 UTC

For master take a look at EShellSidebar.

Comment 5 Milan Crha 2010-01-08 15:32:15 UTC

Created commit abaecf8 in evo master (2.29.5+)

Thanks for a pointer. The master patch is different, I moved a function from itip-view.c to e-unicode.c, and used it on both places. Might be useful on more  places in the future as well, I guess.