After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 605916 - F-Spot uses wrong metadata fields for color profiles in the preferences screen
F-Spot uses wrong metadata fields for color profiles in the preferences screen
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
0.6.x
Other Linux
: Normal minor
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-02 19:11 UTC by Pascal de Bruijn
Modified: 2010-01-04 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use ProductDescription for color profile listing in the Preference dialogs (2.28 KB, patch)
2010-01-02 22:23 UTC, Pascal de Bruijn
none Details | Review

Description Pascal de Bruijn 2010-01-02 19:11:11 UTC
Currently F-Spot primarily uses the ProductName field to display the profiles in the F-Spot preferences screen.

This is however faulty behavior... The problem with ProductName en ManufacturerName is that they contain just that. The ProductDescription field can contain a lot more information, for example:

Displays:
Whitepoint (D65/D50), Gamma, date of calibration, etc.

Printers:
Paper type, ink set, etc.

This is actually very important information to have, when selecting profiles.

I'm currently working on a patch, I hope to post it soon.
Comment 1 Pascal de Bruijn 2010-01-02 22:23:18 UTC
Created attachment 150707 [details] [review]
Use ProductDescription for color profile listing in the Preference dialogs

This patch seems to work well for me.
Comment 2 Pascal de Bruijn 2010-01-03 17:47:06 UTC
Could this patch make it into a 0.6.1.6 release?
Comment 3 Stephane Delcroix 2010-01-04 13:12:03 UTC
commit 54c302df0ffdf459df3222008386923c5af5c944
Author: Pascal de Bruijn <pmjdebruijn@pcode.nl>
Date:   Mon Jan 4 14:06:05 2010 +0100

    Use ProductDescription as cms display name
    
    fixes bgo #605916