After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 605667 - gobject: Don't use G_PARAM_SPEC_VALUE_TYPE when we know the pspec is valid
gobject: Don't use G_PARAM_SPEC_VALUE_TYPE when we know the pspec is valid
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2009-12-29 12:54 UTC by Edward Hervey
Modified: 2010-02-23 17:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gobject: Don't use G_PARAM_SPEC_VALUE_TYPE when we know the pspec is valid (4.63 KB, patch)
2009-12-29 12:54 UTC, Edward Hervey 		none Details | Review
gobject: Don't use G_PARAM_SPEC_VALUE_TYPE when we know the pspec is valid (4.16 KB, patch)
2010-02-23 07:29 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2009-12-29 12:54:36 UTC 
G_PARAM_SPEC_VALUE_TYPE does an extra call to make sure the argument is a valid
GParamSpec. This is unneeded in many places where we know we're dealing with a
valid GParamSpec.
Comment 1 Edward Hervey 2009-12-29 12:54:38 UTC 
Created attachment 150537 [details] [review]
gobject: Don't use G_PARAM_SPEC_VALUE_TYPE when we know the pspec is valid
Comment 2 Matthias Clasen 2010-01-03 00:24:42 UTC 
Looks like a good idea to me.
Comment 3 Edward Hervey 2010-02-23 07:29:56 UTC 
Created attachment 154478 [details] [review]
gobject: Don't use G_PARAM_SPEC_VALUE_TYPE when we know the pspec is valid
Comment 4 Edward Hervey 2010-02-23 07:30:40 UTC 
The new patch is updated to current git head. Ok to apply ?
Comment 5 Matthias Clasen 2010-02-23 16:56:52 UTC 
Comment on attachment 154478 [details] [review]
gobject: Don't use G_PARAM_SPEC_VALUE_TYPE when we know the pspec is valid

Yes, looks fine.
Comment 6 Edward Hervey 2010-02-23 17:48:29 UTC 
commit cecf61d1c3e8ff07b1595641bad85fb9f9b03ddf
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Mon Dec 7 11:23:55 2009 +0100

    gobject: Don't use G_PARAM_SPEC_VALUE_TYPE when we know the pspec is valid
    
    https://bugzilla.gnome.org/show_bug.cgi?id=605667