After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 605185 - Compile error on DirectFB backend due to missing of gdk_keymap_map_virtual_modifiers
Compile error on DirectFB backend due to missing of gdk_keymap_map_virtual_mo...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: [obsolete] Backend: directfb
2.19.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Michael Emmel
: 606003 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-12-22 01:15 UTC by Hiroyuki Ikezoe
Modified: 2010-03-25 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adding a stub (1.29 KB, patch)
2009-12-22 01:15 UTC, Hiroyuki Ikezoe 		committed Details | Review

Description Hiroyuki Ikezoe 2009-12-22 01:15:03 UTC 
Created attachment 150212 [details] [review]
Adding a stub

Compile error on DirectFB backend due to missing of gdk_keymap_map_virtual_modifiers
Comment 1 Javier Jardón (IRC: jjardon) 2009-12-22 02:04:21 UTC 
Review of attachment 150212 [details] [review]:

::: gdk/gdk.symbols
@@ +869,3 @@
 gdk_keymap_translate_keyboard_state
 gdk_keymap_lookup_key
+gdk_keymap_map_virtual_modifiers

This line was already added in commit 03b179c5e8311591f1487a650fec6f20a136e9ca
Comment 2 Hiroyuki Ikezoe 2009-12-22 02:12:16 UTC 
(In reply to comment #1)
> Review of attachment 150212 [details] [review]:
> 
> ::: gdk/gdk.symbols
> @@ +869,3 @@
>  gdk_keymap_translate_keyboard_state
>  gdk_keymap_lookup_key
> +gdk_keymap_map_virtual_modifiers
> 
> This line was already added in commit 03b179c5e8311591f1487a650fec6f20a136e9ca

That was for X11 backend, not for DirectFB backend.
Comment 3 Javier Jardón (IRC: jjardon) 2009-12-22 02:53:09 UTC 
That part is generic, you only need to add the function in the DirectFB file.

Take a look to commit 8daf770a73c53f92f0a1db1e5050bc7c63b7e8d8 for win32 backend
Comment 4 Hiroyuki Ikezoe 2009-12-22 03:23:31 UTC 
That part is not generic at all. I can see __GDK_KEYS_X11_C__ symbol at http://git.gnome.org/browse/gtk+/tree/gdk/gdk.symbols?id=03b179c5e8311591f1487a650fec6f20a136e9ca#n846. The definition for DirectFB is at several lines below it.

And in case of win32 backend, these symbols(__GDK_XXXX_X11_C__ or __GDK_XXXX_DIRECTFB_C__) are not used at all. See gdk/Makefile.am.
Comment 5 Javier Jardón (IRC: jjardon) 2009-12-22 03:35:50 UTC 
Ops, yeah, you are rigth, sorry for the misunderstanding, I think the patch look good then.
Comment 6 Javier Jardón (IRC: jjardon) 2009-12-22 03:37:03 UTC 
Comment on attachment 150212 [details] [review]
Adding a stub

Wait for maintainer aproval
Comment 7 Hiroyuki Ikezoe 2010-01-05 02:27:59 UTC 
*** Bug 606003 has been marked as a duplicate of this bug. ***
Comment 8 Javier Jardón (IRC: jjardon) 2010-03-25 16:03:02 UTC 
Comment on attachment 150212 [details] [review]
Adding a stub

commit ffbd007c50636b0a01fbb95194800593acd67dc7
Comment 9 Javier Jardón (IRC: jjardon) 2010-03-25 16:03:36 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release.

Thank you!.