After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604837 - Add introspection support
Add introspection support
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks: 585444
 
 
Reported: 2009-12-17 13:41 UTC by Johan (not receiving bugmail) Dahlin
Modified: 2010-05-14 22:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add introspection support (7.17 KB, patch)
2009-12-17 13:41 UTC, Johan (not receiving bugmail) Dahlin 		none Details | Review

Description Johan (not receiving bugmail) Dahlin 2009-12-17 13:41:52 UTC 
Vte should support introspection build natively
Comment 1 Johan (not receiving bugmail) Dahlin 2009-12-17 13:41:55 UTC 
Created attachment 149914 [details] [review]
Add introspection support
Comment 2 Christian Persch 2009-12-17 14:17:55 UTC 
Why add -Wno-portability to the automake options? gnome-autogen.sh passes that already.
Comment 3 Johan (not receiving bugmail) Dahlin 2009-12-17 15:18:10 UTC 
Oh, I didn't know automake passed that in, it must be quite new, because when I needed it sometime ago it wasn't included.
Comment 4 Christian Persch 2009-12-17 17:13:47 UTC 
It's in gnome-common 2.28.0, from bug 529120.
Comment 5 Johan (not receiving bugmail) Dahlin 2009-12-17 18:03:04 UTC 
Okay, I'm still using gnome-common 2.24.0 here. I guess it doesn't really hurt to add -Wno-portability twice, just to reduce the warnings. It can eventually be removed, when everybody has upgraded to a distribution which includes 2.28.0 of gnome-common.
Comment 6 Behdad Esfahbod 2009-12-18 10:34:29 UTC 
I'd rather not include m4 files in the tree.

And make sure "make distcheck" passes with a release version of fedora/ubuntu'ish.
Comment 7 Christian Persch 2010-03-17 20:59:36 UTC 
Fixed on master. I changed this to not put the m4 file into vte, in accordance with comment 4. "make distcheck" passes here.
Comment 8 Christian Persch 2010-05-14 20:23:03 UTC 
Behdad: was there a problem with distcheck that your commit a0cec4542963d52b1c1842ea9b450a51262b4c09 tries to fix? distcheck passed for me.
Comment 9 Behdad Esfahbod 2010-05-14 22:27:42 UTC 
(In reply to comment #8)
> Behdad: was there a problem with distcheck that your commit
> a0cec4542963d52b1c1842ea9b450a51262b4c09 tries to fix? distcheck passed for me.

It was crashing on me.  Turned out it was a problem with the gir compiler cache....  Reverted that commit in mater now.