GNOME Bugzilla – Bug 604403
Gtk2::Adjustment new 2.14 funcs
Last modified: 2010-04-20 21:38:06 UTC
Created attachment 149613 [details] [review] adding new 2.14 funcs Gtk 2.14 adds a few new GtkAdjustment funcs, per diff below. The configure one may be important, as it looks like you're forced to use that, as doing the right thing yourself with notifies produces a slew of superfluous changed signals. (Which should be a bug, or a serious misfeature, as it can only slow down correct programs to attempt to help incorrect programs.) The "set_" funcs check for an unchanged value (but perhaps wrongly comparing as gdoubles instead of gfloats) so I suppose should be included. All those specific set functions offer type safety for C, but are really just bloat for perl :-(.
The patch looks fine to me in general. But I wonder if people might not expect the getters to be there, too. Someone following the C API docs might expect to be able to call get_value(), for example. So, should we just wrap these too?
I believe the gets add nothing at all to the present field accessors. Most of the separate C get funcs are unnecessary in a dynamic language like perl, but those ones are particularly useless and I would leave them out for the time being.
OK, you convinced. Committed to master.