After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604313 - Test failures in 0.5.1
Test failures in 0.5.1
Status: RESOLVED FIXED
Product: libgdata
Classification: Platform
Component: General
0.5.x
Other All
: Normal normal
: ---
Assigned To: Richard Schwarting
libgdata-maint
Depends on: 598912
Blocks:
 
 
Reported: 2009-12-10 22:17 UTC by Gilles Dartiguelongue
Modified: 2009-12-11 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build-libgdata-0.5.1.log (53.47 KB, application/octet-stream)
2009-12-10 22:17 UTC, Gilles Dartiguelongue 		  Details
Patch updating # of photos per album to fix broken test (29.21 KB, patch)
2009-12-10 22:35 UTC, Richard Schwarting 		none Details | Review
Patch updating # of photos per album to fix broken test (29.21 KB, patch)
2009-12-10 22:36 UTC, Richard Schwarting 		none Details | Review
Patch updating # of photos per album to fix broken test (1.82 KB, patch)
2009-12-10 22:39 UTC, Richard Schwarting 		accepted-commit_now Details | Review
Patch updating # of photos per album to fix broken test (2.01 KB, patch)
2009-12-11 13:00 UTC, Richard Schwarting 		committed Details | Review

Description Gilles Dartiguelongue 2009-12-10 22:17:23 UTC 
Created attachment 149547 [details]
build-libgdata-0.5.1.log

+++ This bug was initially created as a clone of Bug #598912 +++

Haven't checked git yet, filling so I don't forget about it. Thanks for your attention.
Comment 1 Richard Schwarting 2009-12-10 22:35:31 UTC 
Created attachment 149548 [details] [review]
Patch updating # of photos per album to fix broken test

I'm glad to have tripped this bug, in a way.  It means PicasaWeb now allows 1000 photos per album rather than 500.  

This patch changes our test so we just make sure that gdata_picasaweb_album_get_num_photos_remaining() and gdata_picasaweb_user_get_max_photos_per_album() are returning positive integers, rather than specifying a hard value that Google might break on in the future.
Comment 2 Richard Schwarting 2009-12-10 22:36:54 UTC 
Created attachment 149549 [details] [review]
Patch updating # of photos per album to fix broken test

Weird, my last attempt picked up the wrong patch.
Comment 3 Richard Schwarting 2009-12-10 22:39:36 UTC 
Created attachment 149550 [details] [review]
Patch updating # of photos per album to fix broken test

Ah, generated wrong patch in wrong directory.
Comment 4 Philip Withnall 2009-12-11 07:46:15 UTC 
Review of attachment 149550 [details] [review]:

Looks good. You might want to put some comments in saying that the limit is ~1000, but the test is deliberately weak to avoid having to change it regularly.
Comment 5 Richard Schwarting 2009-12-11 13:00:13 UTC 
Created attachment 149585 [details] [review]
Patch updating # of photos per album to fix broken test

Here's the committed version with the comments added.