After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604047 - Use accessor functions instead of direct access
Use accessor functions instead of direct access
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
2.30.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
evolution[cleanup]
Depends on: 69872
Blocks: 585391
 
 
Reported: 2009-12-08 03:52 UTC by Javier Jardón (IRC: jjardon)
Modified: 2013-09-14 16:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use accessor functions instead direct access (4.15 KB, patch)
2009-12-08 03:54 UTC, Javier Jardón (IRC: jjardon) 		reviewed Details | Review
Use accessor functions instead direct accessv2 (4.48 KB, patch)
2010-02-09 19:52 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-12-08 03:52:25 UTC 
To be ready for GTK+3 should be able to build with -DGSEAL_ENABLE

See http://live.gnome.org/GnomeGoals/UseGseal for more details
Comment 1 Javier Jardón (IRC: jjardon) 2009-12-08 03:54:27 UTC 
Created attachment 149307 [details] [review]
Use accessor functions instead direct access

The GTK+ required version of this patch is 2.18.0

I've used all the api available, still missing: 
GTK_WIDGET_MAPPED()
Comment 2 Milan Crha 2009-12-18 21:07:03 UTC 
Would be better to wait for the missing one and do it in once. Do you have any idea when it'll be available?
Comment 3 Javier Jardón (IRC: jjardon) 2010-01-14 09:42:25 UTC 
Hello Milan,

OK, I'll make a new patch when the accessor were available.
The accessor should be present for GTK+ 2.20, take a look to the blocker bug to stay informed about the progress.
Comment 4 Javier Jardón (IRC: jjardon) 2010-02-09 19:52:14 UTC 
Created attachment 153361 [details] [review]
Use accessor functions instead direct accessv2

Ok the new api just landed in GTK+

I've used 

#if GTK_CHECK_VERSION(2,19,5) for GTK_WIDGET_MAPPED() function, so you only needs to depend on GTK+ 2.18
Comment 5 Matthew Barnes 2010-03-10 04:13:24 UTC 
Thanks for the patch!  I'd like to get this in for 2.30.  Patch builds fine with GTK+ 2.18 and Git HEAD, so committing.

http://git.gnome.org/browse/evolution-data-server/commit/?id=fcd0295bdc9427e51b6db6f1d5ef4acb40e8384a

BTW, I have Evolution about 95% done.  Will upload that when we bump to GTK+ 2.20.