After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603983 - gstdshowvideosink leaking DirectShow objects
gstdshowvideosink leaking DirectShow objects
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.x
Other Windows
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-12-07 14:54 UTC by Stephen McNamara
Modified: 2009-12-07 18:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixed version of the header. (3.34 KB, text/plain)
2009-12-07 14:54 UTC, Stephen McNamara 		Details

Description Stephen McNamara 2009-12-07 14:54:45 UTC 
Created attachment 149255 [details]
Fixed version of the header.

gstreamer/gst-plugins-bad/tree/sys/dshowvideosink/dshowvideosink.h should declare a virtual destructor on the RendererSupport class, otherwise the destructors of the derived render support objects will not be called.
Fixed header attached.
Comment 1 Michael Smith 2009-12-07 18:17:22 UTC 
Ugh, I hate C++. 

Thanks for the patch - committed it to trunk.

For future reference: please provide changes in patch format, see http://gstreamer.freedesktop.org/wiki/SubmittingPatches
Comment 2 Michael Smith 2009-12-07 18:25:05 UTC 
Also I noticed after pushing your patch that it had a mistake - RenderSupport rather than RendererSupport.

Patches that you've actually tested are much more helpful than ones that haven't been tested.