After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603821 - add support for n900
add support for n900
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
1.5.2
Other Linux
: Normal enhancement
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-12-04 21:26 UTC by javiermon
Modified: 2010-02-23 18:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Nokia default icon (86.31 KB, image/x-ico)
2010-01-30 22:56 UTC, Pavel Antonov
  Details
Patch adds support for Nokia N900 phone (Maemo device) (7.19 KB, patch)
2010-01-31 13:07 UTC, Pavel Antonov
needs-work Details | Review
Patch adds support for Nokia N900 phone (Maemo device) (7.13 KB, patch)
2010-02-07 20:11 UTC, Pavel Antonov
none Details | Review
N900 png. (11.55 KB, image/png)
2010-02-11 19:10 UTC, Vish
  Details
Icon source and rendered (83.86 KB, application/x-gzip)
2010-02-12 17:06 UTC, Vish
  Details
Patch adds support for Nokia N900 phone (Maemo device) (5.91 KB, patch)
2010-02-23 16:30 UTC, Pavel Antonov
committed Details | Review

Description javiermon 2009-12-04 21:26:23 UTC
Hi

the n900 is out and it would be great if banshee supported it. It behaves as a usb mass storage but also supports media art.

thanks
Comment 1 Nick A 2009-12-29 13:28:43 UTC
This would be a great thing to have.  It is a great phone which is debian based, but as has been said, using it as a mass storage is likely the easiest way to do it.
Comment 2 javiermon 2009-12-29 14:35:01 UTC
This is my current .is_audio_player
(stored in my external microSD card /media/mmc1):

cat .is_audio_player 
audio_folders=Music/
output_formats=application/ogg,audio/x-ms-wma,audio/mpeg
input_formats=application/ogg,audio/x-ms-wma,audio/mpeg

Afaik the .is_audio_player spec only supports audio, not video. Also the cover art is missing and I have to manually upload it to the device with a small script.
Comment 3 javiermon 2009-12-31 18:32:14 UTC
Additionally it would be great to support both n900 with and without an external microsd card, I don't know if banshee can handle 2 diferent storage places (in this case mount points) for a single music device.
Comment 4 Jack Deslippe 2010-01-08 20:49:16 UTC
Not sure if this is going to help you, but for cover art you might just need to add something like the following to your .is_audio_player file

cover_art_file_name=cover.jpg
cover_art_file_type=jpeg
cover_art_size=320

(this is what is used for rockbox devices).  Anyway, I have experience with the android support for Banshee but don't own an n900.  I imagine you can you mostly just copy what we did for android, though.  Creating a new class for maemo devices.  If you are in the Bay Area (or anyone with n900) is in Bay Area, perhaps we could meet and do it together at LUG meeting or something.

Look in src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/
and
src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage.addin.xml
Comment 5 Gabriel Burt 2010-01-26 17:57:02 UTC
What is the usb vendor id/product id for the n900?  you can run the lsusb command to find out
Comment 6 André Klapper 2010-01-26 19:31:26 UTC
Bus 002 Device 006: ID 0421:01c7 Nokia Mobile Phones
  and
Bus 002 Device 007: ID 0421:01c7 Nokia Mobile Phones
  here.
Comment 7 Gabriel Burt 2010-01-26 21:58:38 UTC
Ok, couple more questions:

1) What media formats does it play?
2) What folder(s) does it store audio in?
3) What folder(s) does it store video in?
4) Does it support playlists?  If so, what format of playlists (m3u, pls, etc)?  And in what folder does it expect them?
5) Does it support album art?  How - embedded in the files, or in the folder with the music?  What file format/size are ideal?
6) Do audio or video files transferred to the device have to be put in a particular folder structure?
7) Do you know of an icon for the n900 that we can use?
Comment 8 javiermon 2010-01-26 23:01:08 UTC
I'll try to answer the question the best I can:

1) What media formats does it play?
out of the box: 
Music playback file formats: .wav, .mp3, .AAC, .eAAC, .wma, .m4a
Video playback file formats: .mp4, .avi, .wmv, .3gp; codecs: H.264, MPEG-4, Xvid, WMV, H.263

However, community packages are available for playing ogg audio & video. 

2) What folder(s) does it store audio in?
The o.s. uses tracker to search for all types of media in /home/user/MyDocs as well as /media/mmc1 (external micro sd-card)

I particulary use /media/mmc/Music/ and /media/mmc/Video/

3) What folder(s) does it store video in?
I believe the same answer in question 3 applies.

4) Does it support playlists?  If so, what format of playlists (m3u, pls, etc)?
 And in what folder does it expect them?

I don't really know. I created one but couldn't find it in the root system or anywhere else, I'm guessing it's stored in trackers database.

5) Does it support album art?  How - embedded in the files, or in the folder
with the music?  What file format/size are ideal?

It supports embedded, cover.jpg inside the album folder and also part of the spec here: http://live.gnome.org/MediaArtStorageSpec

In my own experience I've always uploaded media cover art to /home/user/.cache/media-art/ in the format: album-7215ee9c7d9dc229d2921a40e899ec5f-5664e09816f3c1a6ddaecf26e354cce1.jpeg
NOTE: In my own experience and for some reason I always have to put the 1st part of the cover name to 7215ee9c7d9dc229d2921a40e899ec5f which is the md5 for empty artist ("").

As for the file sizes it creates thumbnails of 124x124 JPEG, so I guess that should be fine.

6) Do audio or video files transferred to the device have to be put in a
particular folder structure?

Nope as it uses tracker for searching stuff.

I use the same structure as in banshee: Artist/Album/tracknumber-trackname.extension

7) Do you know of an icon for the n900 that we can use?
Not that I'm aware of :(


My main concern is that if banshee could offer some degree of flexibility on how to copy files inside the device, because I for instance like to have everything in the external sdcard. Also I like having it on Music / Video folders.

I understand that this issues can make support this device more difficult and maybe using a .is_audioplayer file would be fine.

Thanks
Comment 9 javiermon 2010-01-26 23:10:07 UTC
One more thing which I don't know if it matters, but when I attach the n900 to a computer and select the USB Mass Storage option my device is mounted on my linux system in "/media/Nokia N900" (the actual n900 storage) & /media/1190-4587/ (the external micro sd-card)

Thanks
Comment 10 André Klapper 2010-01-26 23:13:14 UTC
> 1) What media formats does it play?

http://nds1.nokia.com/phones/files/guides/Nokia_N900_UG_en.pdf says:
"The supported video file formats are: 3GP, MOV, AVI, MP4, WMV, and ASF. The supported audio file formats are: MP3, AAC, WMA, M4A, AMR, AWB, and WAV."

> 2) What folder(s) does it store audio in?

By default it's /home/user/MyDocs/.sounds

> 3) What folder(s) does it store video in?

By default it's /home/user/MyDocs/.videos

> 4) Does it support playlists?

Yes, see http://wiki.maemo.org/Documentation/Maemo_5_Developer_Guide/Using_Multimedia_Components/Media_Application_Framework_%28MAFW%29#Playlists

>  If so, what format of playlists (m3u, pls, etc)?

http://nds1.nokia.com/phones/files/guides/Nokia_N900_UG_en.pdf says:
"The Media player application supports M3U, PLS, ASX, WAX, WVX, and WPL playlists."

>  And in what folder does it expect them?

Good question, don't know. http://talk.maemo.org/showthread.php?p=492194#post492194 is also waiting for the same answer.

> 5) Does it support album art?

Yes.

> How - embedded in the files, or in the folder
> with the music?  What file format/size are ideal?

Not sure at all... I think either album art needs to be included in the metadata of a file, or there must be a picture file containing the word 'cover' in its filename plus in the same directory.

> 6) Do audio or video files transferred to the device have to be put in a
> particular folder structure?

Not that I know - tracker-daemon running on the N900 will find it anyway.

> 7) Do you know of an icon for the n900 that we can use?

There is none that I know of.
Comment 11 André Klapper 2010-01-27 11:48:49 UTC
(In reply to comment #7)
> 7) Do you know of an icon for the n900 that we can use?

I've filed a request at http://live.gnome.org/GnomeArt/ArtRequests
Comment 12 Vish 2010-01-27 14:07:22 UTC
(In reply to comment #11)
> (In reply to comment #7)
> > 7) Do you know of an icon for the n900 that we can use?
> 
> I've filed a request at http://live.gnome.org/GnomeArt/ArtRequests

I'v taken the request , I could get one done. 
- What sizes do you want the icon? [some app just use a 48px icon and render the smaller sizes... not sure how Banshee does it]
- How soon do you want it done by? [apart from asap ;)]
Comment 13 Gabriel Burt 2010-01-27 19:16:35 UTC
(In reply to comment #12)
> I'v taken the request , I could get one done. 
> - What sizes do you want the icon? [some app just use a 48px icon and render
> the smaller sizes... not sure how Banshee does it]

128x128  16x16  22x22  32x32  48x48 are what we have for our Android G1 icon.  We use the large size when you click on the DAP source itself - see http://2.bp.blogspot.com/_MXUP18ra1ik/S2CHo9OAmAI/AAAAAAAAA18/AyNBwIZc-HU/s1600/banshee-1.5.3-goodlies.png

> - How soon do you want it done by? [apart from asap ;)]

We're putting out 1.5.3 today, so it's too late for that.  The next release is 1.5.4 on Feb 24th.
Comment 14 Vish 2010-01-27 20:04:27 UTC
(In reply to comment #13)
> (In reply to comment #12)
> > I'v taken the request , I could get one done. 
> > - What sizes do you want the icon? [some app just use a 48px icon and render
> > the smaller sizes... not sure how Banshee does it]
> 
> 128x128  16x16  22x22  32x32  48x48 are what we have for our Android G1 icon. 
> We use the large size when you click on the DAP source itself - see
> http://2.bp.blogspot.com/_MXUP18ra1ik/S2CHo9OAmAI/AAAAAAAAA18/AyNBwIZc-HU/s1600/banshee-1.5.3-goodlies.png
> 
> > - How soon do you want it done by? [apart from asap ;)]
> 
> We're putting out 1.5.3 today, so it's too late for that.  The next release is
> 1.5.4 on Feb 24th.

Thanks . I'll get them done in a couple of weeks.
Comment 15 Pavel Antonov 2010-01-30 22:56:10 UTC
Created attachment 152651 [details]
Nokia default icon
Comment 16 Pavel Antonov 2010-01-30 22:56:25 UTC
Just trying to implement support for Nokia N900 myself and run into issue that DirectoryScannerPipelineElement is not allow to use directories started with dots.

And wow... Looks like it's already in progress by banshee team! Great work! Thanks! 


There defult icon file 256x256 for N900 provided by Nokia. I attach it, may be it will help.
Comment 17 Gabriel Burt 2010-01-30 23:24:03 UTC
Pavel, have you tested your work with the latest from master?  I think the directory-scanner bug should be fixed.

You'll attach your patch here when it's ready, right?  Feel free to attach it even if it's not ready, if you're short on time to work on it.

Where did you get that Nokia file from - do you have a URL?  Is it released under a free license?  I'm not sure it'll be useful, since it's at a strange (for GNOME/Tango device icons) angle, but maybe it'll be useful - if it's Free.
Comment 18 Pavel Antonov 2010-01-30 23:33:38 UTC
Not yet... will try to build it now.

Icon come with device, used as device icon under Windows. Know nothing about license on this art.
Comment 19 Pavel Antonov 2010-01-30 23:53:26 UTC
It's working with master branch.
Comment 20 Pavel Antonov 2010-01-31 00:59:19 UTC
Album art should be named cover.jpg, placed into album directory and have size 200x200 px
Comment 21 Pavel Antonov 2010-01-31 13:07:14 UTC
Created attachment 152673 [details] [review]
Patch adds support for Nokia N900 phone (Maemo device)

I have added same mime types that Andriod supports. 

Maemo player uses gstreamer, and virtually support everything that supported by gstreamer. So if anybody provide full list i can update it.
Comment 22 Gabriel Burt 2010-02-01 19:51:58 UTC
Review of attachment 152673 [details] [review]:

Thanks Pavel, looks pretty good.

1. You've got a few tabs in MaemoDevice.cs
2. Please update the Authors/copyright info for that file too
3. You have vendor = HTC, should be Nokia
Comment 23 Pavel Antonov 2010-02-07 20:11:32 UTC
Created attachment 153228 [details] [review]
Patch adds support for Nokia N900 phone (Maemo device)
Comment 24 Pavel Antonov 2010-02-07 20:18:10 UTC
Another N900 icon that can be used http://talk.maemo.org/showthread.php?t=41614
Comment 25 Gabriel Burt 2010-02-07 20:41:44 UTC
Thanks Pavel.  Does the n900 really have a AmazonMP3 app/support like Android does?
Comment 26 Pavel Antonov 2010-02-07 22:12:13 UTC
No, I thought it's Banshee feature - to store buyed tracks in special directory. So it's ok to remove it?
Comment 27 Gabriel Burt 2010-02-07 22:16:25 UTC
Yeah, it should be removed.
Comment 28 Vish 2010-02-11 19:10:56 UTC
Created attachment 153569 [details]
N900 png.

Finally , got to completing the icon in all sizes.
Attaching the png for now.
Is it good to go ?
Comment 29 Pavel Antonov 2010-02-11 22:32:16 UTC
I will add icon loading.
Comment 30 Vish 2010-02-12 17:06:06 UTC
Created attachment 153638 [details]
Icon source and rendered

Attaching the rendered icons and the source.
I'v just named the icons N900 , might need renaming though.
Comment 31 Pavel Antonov 2010-02-23 16:30:41 UTC
Created attachment 154511 [details] [review]
Patch adds support for Nokia N900 phone (Maemo device)

Added support for icons, removed amazon shop support
Comment 32 Gabriel Burt 2010-02-23 18:42:41 UTC
Vish, what is your full name?  Thanks for the icons!
Comment 33 Vish 2010-02-23 18:48:13 UTC
(In reply to comment #32)
> Vish, what is your full name?  Thanks for the icons!

np..

K. Vishnoo Charan Reddy 

I'm closing the art request too.
Comment 34 Gabriel Burt 2010-02-23 18:55:25 UTC
Comment on attachment 154511 [details] [review]
Patch adds support for Nokia N900 phone (Maemo device)

Thanks Pavel, committed.
Comment 35 Gabriel Burt 2010-02-23 18:55:54 UTC
Thank you Vish, too - I've added your icons.