After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603801 - Use gupnp rather than a code copy of miniupnp
Use gupnp rather than a code copy of miniupnp
Status: RESOLVED WONTFIX
Product: vino
Classification: Applications
Component: Server
unspecified
Other Linux
: Normal enhancement
: 3.2
Assigned To: Vino Maintainer(s)
Vino Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-12-04 16:04 UTC by Emilio Pozuelo Monfort
Modified: 2020-11-12 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Emilio Pozuelo Monfort 2009-12-04 16:04:40 UTC
Hi,

Vino currently ships a code copy of miniupnp which uses for UPnP support. I don't like code copies, so I think Vino should use libgupnp, which by the way is more GLibish :)
Comment 1 Jussi Kukkonen 2011-02-09 11:10:22 UTC
Not to mention that there is GUPnP-IGD helper which probably does what vino wants to do in one method call (I'm assuming UPnP is just used to open the port).

http://folks.o-hand.com/ross/gupnp-docs/gupnp-igd/
Comment 2 Jeremy Bicha 2011-07-26 03:20:51 UTC
Debian & Ubuntu now have miniupnpc in their repositories. If miniupnp has to be used, it would be nice (for security updates among other reasons) to at least have an option of using the system-installed version rather than a bundled library.

http://packages.qa.debian.org/miniupnpc
Comment 3 Michael Biebl 2012-03-16 23:11:33 UTC
Hi,

could we have some input from upstream if building against a miniupnpc system lib would be acceptable?

We do have the following patch in the Debian patch tracker
http://patch-tracker.debian.org/patch/series/view/vino/3.2.2-1/05_use-system-miniupnpc.patch
Comment 4 Bastien Nocera 2013-01-28 18:25:05 UTC
Using gupnp or gupnp-igd directly would be nicer than changing which library we link against (especially when it's not part of our stack).


(In reply to comment #1)
> Not to mention that there is GUPnP-IGD helper which probably does what vino
> wants to do in one method call (I'm assuming UPnP is just used to open the
> port).
> 
> http://folks.o-hand.com/ross/gupnp-docs/gupnp-igd/

I think it also uses it to query which is the outside-visible hostname to connect to.
Comment 5 André Klapper 2020-11-12 12:24:48 UTC
Vino is not under active development anymore and unmaintained.

Please use gnome-remote-desktop instead.

Closing this report as WONTFIX to reflect reality.