After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603520 - Need to add script mapping to check for Pidgin with a capital "P"
Need to add script mapping to check for Pidgin with a capital "P"
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.27.x
Other All
: Normal normal
: 2.28.2
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-12-01 19:31 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-12-05 23:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix (886 bytes, patch)
2009-12-05 23:52 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2009-12-01 19:31:46 UTC
From the Orca list:

~~~~~~~~~~~~
Hi All,
I made the rather unpleasant discovery today that ArchLinux upgrading
pidgin to 2.6.4 broke the orca script for it completely.  I have orca
2.28.1 at the moment from the arch repository.
I wonder if this sort of breakage is reason enough to run orca from the
source repository?  I've never done it before, and so am not quite sure
what to expect.  Might anybody be able to give me a few tips on how to
go about it?  Steve, I believe you're already doing this sort of thing?
I presume I first need to remove the Arch package of orca to avoid
contamination.
Thanks much for any advice,
Zack.
~~~~~~~~~~~~

Having just (quickly) tried Pidgin 2.6.4 in OpenSolaris, I am still seeing appropriate events being emitted. So my guess is that they changed the hierarchy we're counting on when identifying what to speak.
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-12-05 23:52:20 UTC
Created attachment 149183 [details] [review]
fix

What I didn't notice when I was doing quick lunch-break triage is that beginning with Pidgin 2.6.4, the app name claims to be Pidgin with a capital "P". This breaks the script mapping and causes the default script to kick in.

The fix is to handle this case in settings.py. Ultimately we should probably consider dealing with this globally, but for now, problem solved.

Committed to both master and the gnome-2-28 branch.