GNOME Bugzilla – Bug 603053
"Import tags" category sounds like an action
Last modified: 2010-03-01 17:06:59 UTC
Until recently I kept selecting the category "Import Tags" expecting the F-spot app to ask/allow me to import tags from some location/app. The "Import tags" option sounds more like an action a user can perform rather than a collection of tags which are automatically added from the imported photos. It would be better if this option is renamed as either "Imported Tags" or "External Tags" or something of the sort , so that the category sounds less like an action.
Created attachment 150915 [details] [review] Rename "Import Tags" to "Imported Tags" Hi, This bug has been marked as a lucid Paper cut, As I am just starting out with some f-spot development I thought this would be an easy one to attempt. The attached patch renames the "Import Tags" tag to "Imported Tags" to make it sound less like an action. However, name aside... (Please put forward a better name!) the patch only works for new users of f-spot as the "Import Tags" is actually stored in the photos.db in the tags table. Existing users who use the patch would find it would create another category "Imported Tags" and yet still display the old "Import Tags". I could add code to check for the presence of the old tag and rename to the new one. But this seems like quite a hack. How does f-spot handle database changes such as this? Is there a database update script or something that runs on install of a new f-spot version? Regards Iain Churcher
Created attachment 150937 [details] [review] Rename "Import Tags" to "Imported Tags" Ver 2 Hi, Thanks to a tip from Maxxer I have updated the patch to update the Updater.cs file to create a new database update (17.1) which will rename the existing 'Import Tag' to 'Imported Tags' This means for those with existing imported tags the patch will correctly work. Comments (and any further suggestion to the name change) Welcome Regards Iain Churcher
Looks good, merged. Thanks!