After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602802 - Home Folder from shell-uri-util.c does not get translated
Home Folder from shell-uri-util.c does not get translated
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-11-24 05:35 UTC by Marina Zhurakhinskaya
Modified: 2009-11-24 20:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
include "config.h" in all .c files (8.19 KB, patch)
2009-11-24 14:19 UTC, Dan Winship 		committed Details | Review
Replace includes of glib/gi18n.h with glib-gi18n-lib.h (1.42 KB, patch)
2009-11-24 15:37 UTC, Florian Müllner 		committed Details | Review

Description Marina Zhurakhinskaya 2009-11-24 05:35:02 UTC 
The translation from the translation files does not get picked up.
Comment 1 Dan Winship 2009-11-24 14:19:47 UTC 
Created attachment 148392 [details] [review]
include "config.h" in all .c files

traditionally this problem was often caused by forgetting to #include
"config.h", which would result in _() being defined as a no-op. Apparently
the i18n header files got changed at some point to not require
correct anyway, and it points out a problem in shell-global.c
Comment 2 Colin Walters 2009-11-24 14:24:00 UTC 
Review of attachment 148392 [details] [review]:

I guess we're fairly inconsistent with our C include ordering; oh well.

Engage warp drive.
Comment 3 Dan Winship 2009-11-24 14:44:45 UTC 
Comment on attachment 148392 [details] [review]
include "config.h" in all .c files

Attachment 148392 [details] pushed as dd8f05c - include "config.h" in all .c files
Comment 4 Florian Müllner 2009-11-24 15:37:41 UTC 
Created attachment 148397 [details] [review]
Replace includes of glib/gi18n.h with glib-gi18n-lib.h

Libraries should include gi18n-lib.h instead of gi18n.h. In addition to the file mentioned in this bug, there were two wrong includes in tray - replaced these as well, although a quick grep did find any translated strings in there.
Comment 5 Dan Winship 2009-11-24 20:28:51 UTC 
yup, that does it