After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602551 - dshowvideosink window close doesn't cause gst-launch to exit
dshowvideosink window close doesn't cause gst-launch to exit
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.17
Other Windows
: Normal normal
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-21 01:26 UTC by David Hoyt
Modified: 2010-08-06 00:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes dshowvideosink.cpp (498 bytes, patch)
2009-11-21 01:27 UTC, David Hoyt 		committed Details | Review

Description David Hoyt 2009-11-21 01:26:17 UTC 
I'm providing a small patch so that dshowvideosink.cpp causes gst-launch to exit if the window is closed. Without this, the video would stop and the audio continues playing for a few seconds and the application doesn't exit.
Comment 1 David Hoyt 2009-11-21 01:27:35 UTC 
Created attachment 148205 [details] [review]
Fixes dshowvideosink.cpp
Comment 2 Tim-Philipp Müller 2010-08-06 00:02:56 UTC 
Looks like this was committed as part of Julien's code-drop commit:

 commit a51d318759b07eca60811e3d47d8e81b6d12cb8c
 Author: Julien Moutte <julien@fluendo.com>
 Date:   Fri Jul 23 19:41:29 2010 +0200

    dshowvideosink: Improvements contributed from the Moovida projet.
    
    * Inherit from GstVideoSink
    * Implement GstNavigation interface
    * Proper COM initialization for threaded environments
    * Fix Window resource leak
    * Add EVR support for better video scaling on Windows Vista and above
    * Only apply PAR scaling when the keep_aspect_ratio property is set to stay
    consistent with the other Linux sinks
    * Prevent an infinite loop with the wndproc chain
    * Fix debugging messages to use the object instance