GNOME Bugzilla – Bug 602223
Can't hide docks with Tab in single-window mode
Last modified: 2010-04-01 18:17:33 UTC
I don't know if this is planned and/or connected to the new options to integrate the toolbox/docks into the main window, but the possibility to hide them with TAB I would consider essential, please don't remove it!
Yes, tab will work also in single-window mode, it's just not implemented yet. I'll use this bug report as a reminder. Putting on the 2.8 milestone list.
The main functionality is in place, but I'll keep this report open until the flicker problem is fixed: commit 18f3be6bd3438c828648a93174595ebd3f4a632c Author: Martin Nordholts <martinn@src.gnome.org> Date: Tue Feb 23 20:21:08 2010 +0100 Bug 602223 - Can't hide docks with Tab in single-window mode Add a "hide-docks" config and connect the Windows->Hide docks menu item to it. Also connect the image window to the config property so it can hide/show its docks when it needs to. Also add and use a utility function gimp_image_window_keep_canvas_pos() to ensure that the image in the window remains fixed when toggling visiblity of docks. One problem: When GimpDrawTool is active on the canvas, there is flicker. The end position is correct though. Also add regression testing for this fix to test-ui.c
This gets rid of the severe flickering, but before I close this bug report I want to make the layer and selection boundaries depend on the image offset into the window rather than the image offset into the display shell, to get rid of that flicker too while toggling visibility of docks. commit ed5830fb7b7657232315f7c54385cc3aee32d911 Author: Martin Nordholts <martinn@src.gnome.org> Date: Thu Feb 25 21:37:02 2010 +0100 app: Pause tool drawing while hiding docks in single-window mode Freeze the active tool until the UI has stabilized. If it draws while we hide widgets there will be flicker. See bug 602223.
Correction: The boundaries should not depend on the image offset into the display shell, but rather the offset from the image origin, so that when panning an image the layer boundary would remain fixed. This would also get rid of the flicker when toggling docked dock visibility. This is a detail however, and I'm not sure it would be worth the effort. I might fix it later, but I want to close this as FIXED now anyway.
Does this also allow us to assign a different key to hide the docks? Because in Windows hitting TAB after showing the docks in 2.6.x and adjusting things in them always tabbed through the controls instead of re-hiding them as the dock had the keyboard focus, which is a rather big pain...
Kurt, that focus problem is a bug then that needs to be fixed instead of being worked around.