Created attachment 147706 [details] [review]
[StAction, StPopup] Import NbtkAction, NbtkPopup

Review of attachment 147706 [details] [review]:

::: src/st/st-popup.c
@@ +177,3 @@
+{
+  gint i;
+  gfloat min_height, nat_height;

tried compiling with this patch.. got two uninitialized warnings, being treated as errors. 
min_height and nat_height needs to be initialized with zero.(in case, if children->len is zero, we may run into issues)

Created attachment 147926 [details] [review]
[StAction, StPopup] Import NbtkAction, NbtkPopup

Modifications:

* Adjusted to use st_theme_node in allocation code

Created attachment 147927 [details] [review]
[tests] Add popup.js test

Review of attachment 147926 [details] [review]:

The procedure I followed for all the other St widgets was:

 - Use MX as a source rather than NBTK (MX was then a branch, now is a separate module.) This way, the MX and St sources are related *only* by the sed job, and not by whitespace differences.
 - Have a commit that imported the file with only the st => mx change
 - Do other changes, like st_theme_node usage on top of that

(I wasn't always consistent with whether I fixed up includes for differences in compilation environment in the first commit, but I think it's probably cleanest not to - to only add them to the Makefile.am in the followup change.)

I'd really like to see this done the same way.

Review of attachment 147927 [details] [review]:

Looks OK to me

::: tests/interactive/popup.js
@@ +32,3 @@
+    }
+    popup.show();
+    popup.set_position(100, 100);

Is it weird (does it look like a malfunctioning test to someone trying it out) to have the popup pop up right over the button rather than beneath it?

::: tests/testcommon/test.css
@@ +57,3 @@
+    background-color: #ffffff;
+}
+StPopup StButton {

Would rather it stayed consistent with the rest of the file and had blank lines between the different styles.

I think at this point if we wanted to do this we'd start from scratch, so I'm going to close this to clean up the bug list a little bit.