GNOME Bugzilla – Bug 600640
Select all overzealous
Last modified: 2021-05-17 16:16:10 UTC
I keep typing Ctrl-A to select all the text in a field, for example an image title, but Postr takes this to mean "select all images". So if I type Ctrl-A and Ctrl-V, meaning to select all the text in the current field and replace it with the buffer, I instead get every single image's title set to the buffer text! I'm currently using Postr for the first time and have entered this key combination three times so far out of habit. I'm not aware of any other Gnome programs which behave like this when the focus is in a text field. I propose that Ctrl-A be left at the usual meaning when editing a text field. While I'm at it, a way to move up or down in the list of images using the keyboard would be handy too. Thanks, Matt
I think that this behaviour should be changed too. Perhaps when you click on an image thumbnail and then press Ctrl+A should all of the images be selected.
+1 on the need for forward/back image by keyboard.
Created attachment 148620 [details] [review] patch [1/2] Replace the shortcut Ctrl+A with Ctrl+E for the select all images. And it's added the sortcut Ctrl + I to invert the selection.
Created attachment 148621 [details] [review] patch [2/2] Allows the user to navigate in the image list with prev/next image operation and use the Ctrl+Up and Ctrl+Down shortcuts for these operations
Created attachment 148622 [details] [review] patch [2/2] a little improvement
Created attachment 148627 [details] [review] patch [2/2] The treeview grab the focus after the selection is moved.
Review of attachment 148620 [details] [review]: I just commited this one. Now it is possible to use Ctrl+A to select all when the user is editing a text and Ctrl+E to select the images. Thanks
Review of attachment 148627 [details] [review]: The keyboard navigation uses Alt+Up/Down, not Ctrl. However, I wonder if using Alt+Up/Down should let the focus on the text entry. It makes more sense to me.
Created attachment 150091 [details] [review] patch [2/2] Fix the comment in the commit and let the focus on the text entry.
Review of attachment 150091 [details] [review]: Francisco, may you polish the focus according my comments? Thanks! ::: src/postr.py @@ +540,3 @@ + selection.unselect_all() + self.thumbview.set_cursor(path) + self.title_entry.grab_focus() Instead of title_entry, it could be: widget = gtk_grab_get_current() ... and then: gtk_widget_grab_focus (widget) So, if the user was editing the description it would look weird the focus changing from widget, and only navigating through photos. @@ +561,3 @@ + selection.unselect_all() + self.thumbview.set_cursor(path) + self.title_entry.grab_focus() Idem.
Created attachment 159267 [details] [review] patch [2/2] thanks Germán for your comments, I think that gtk_grab_get_current() doesn't work in this case, however I tried make it work asking every field if is_focus(), and saving the focus widget, then the widget grab_focus().
*** Bug 648017 has been marked as a duplicate of this bug. ***
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/postr/-/issues/8.