After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 600531 - On systems that run metacity, keybindings for compiz or other wm will be shown in the gnome-keybinding-properties dialog.
On systems that run metacity, keybindings for compiz or other wm will be show...
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Keybinding
git master
Other All
: Normal major
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 604295 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-11-03 10:12 UTC by Wang Xin
Modified: 2009-12-11 10:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to fix the problem (734 bytes, patch)
2009-11-03 10:22 UTC, Wang Xin
committed Details | Review

Description Wang Xin 2009-11-03 10:12:58 UTC
According to the comment in gnome-keybinding-properties.c:append_keys_to_tree_from_file, keybindings that apply to a window manager that's not the one we're running should not be added into gnome-keybinding-properties dialog.

But according to the following code, if keylist->wm_name is not NULL and if it is contained in wm_keybinding which contains running wm, the keylist will be freed. This is actually opposite to what the comment says. So on systems that run metacity, keybindings for compiz or other wm will be shown in the gnome-keybinding-properties dialog.

  /* If there's no keys to add, or the settings apply to a window manager
   * that's not the one we're running */
  if (keylist->entries->len == 0
      || (keylist->wm_name != NULL && strv_contains (wm_keybindings, keylist->wm_name))
      || keylist->name == NULL)
    {
      g_free (keylist->name);
      g_free (keylist->package);
      g_free (keylist->wm_name);
      g_array_free (keylist->entries, TRUE);
      g_free (keylist);
      return;
    }
Comment 1 Wang Xin 2009-11-03 10:22:03 UTC
Created attachment 146809 [details] [review]
patch to fix the problem
Comment 2 Jens Granseuer 2009-11-04 17:54:43 UTC
Comment on attachment 146809 [details] [review]
patch to fix the problem

commit 7c82b5b5cc89c0934f13e66175f3881b8f5528f4
Author: Wang Xin <...>
Date:   Wed Nov 4 18:53:37 2009 +0100

    [keybindings] Show shortcuts for the active window manager
    
    Actually display the bindings for the running window manager instead
    of all others (bug #600531).
Comment 3 Jens Granseuer 2009-12-11 10:40:35 UTC
*** Bug 604295 has been marked as a duplicate of this bug. ***