GNOME Bugzilla – Bug 600499
share bar finetuning
Last modified: 2009-11-03 01:59:52 UTC
There are a few things that could be improved wrt to the share bar: - xdg-user-dirs-update resets PUBLICSHARE to $HOME under some circumstances. Sharing $HOME is obviously a bad idea, and we should not show the share bar on $HOME ever, I think. Also, we should probably refuse to turn on sharing if PUBLICSHARE is $HOME. - Currently the share bar doesn't differentiate between enabled and disabled. Imo, the messages should be slightly different. If sharing is disabled, the message should be as it is currently: "You can share files from this folder..." But if sharing is enabled, the message should be something like: "Files in this folder are shared..."
Fixed the first part. We actually already had code to avoid sharing $HOME, but it wasn't used when looking up the directory in the share extension. We can't fix the second part. It's easy if you have 3 different folders for ObexPush, ObexFTP and DAVS sharing. But it gets more complicated when you need to tell the user that: You can share files from this folder using HTTP, this folder is already shared using ObexFTP over Bluetooth. And what do we show when the public directory is the same as the downloads directory? Ideas welcome, in a separate bug... See also: https://bugzilla.gnome.org/show_bug.cgi?id=558244#c3