GNOME Bugzilla – Bug 599573
Remember dialog defaults between Gimp sessions
Last modified: 2018-03-26 18:43:41 UTC
I set the value of "grow selection" to 2 but after a Gimp restart it is reset to 1 though I have set "save tool options on exit" in the preferences. I guess this menu entry is not seen as a tool, but IMHO it would be nice to also have this value saved.
Bug 63610 and Bug 120829 are related, although they specifically mention plug-ins.
Changing the bug title because this affects much more than the grow radius value, and a general purpose solution is about to land in master. Only for core dialogs tho.
Remember the "add layer mask" settings: commit 0b7381a8223f1a02e1c1c0b9e7609544d82e8fce Author: Benoit Touchette <draekko.software+gimp@gmail.com> Date: Tue Aug 23 19:18:20 2016 +0200 Bug 759601 - Add/Remove layer masks by clicking the layer preview Quite heavily modified by Mitch to address the more general issues mentioned in comment 35 of the bug: - Remember the added mask's type and the invert boolean in GimpDialogConfig - Add new prefs page "Dialog Defaults" which will contain only stuff from GimpDialogConfig and can be reset separately - Remove static mask variables from layers-commands.c and use the new config values for both interactive mask adding with the dialog, and for the shortcut based method - Add a button to the layers dialog which supports add, add with last values, delete, apply - Add modifier-click shortcuts on the layer preview with the same modifiers as on the button app/actions/layers-actions.c | 22 +++++++++- app/actions/layers-commands.c | 134 +++++++++++++++++++++++++++++++++++++++----------------- app/actions/layers-commands.h | 2 + app/config/gimpdialogconfig.c | 41 ++++++++++++++--- app/config/gimpdialogconfig.h | 2 + app/config/gimprc-blurbs.h | 6 +++ app/dialogs/preferences-dialog.c | 45 +++++++++++++++++-- app/widgets/gimphelp-ids.h | 1 + app/widgets/gimplayertreeview.c | 68 +++++++++++++++++++++++----- 9 files changed, 260 insertions(+), 61 deletions(-)
And the "New Layer" dialog: commit 981a1b9c2ec263eb84024389a54621d15ccbefa8 Author: Michael Natterer <mitch@gimp.org> Date: Wed Aug 24 12:33:56 2016 +0200 Bug 599573 - Remember dialog defaults between Gimp sessions Remeber the "New Layer" dialog settings in GimpDialogConfig. app/actions/layers-commands.c | 52 +++++++++++++++++++++++++--------------------------- app/config/gimpdialogconfig.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ app/config/gimpdialogconfig.h | 4 ++++ app/config/gimprc-blurbs.h | 6 ++++++ app/dialogs/preferences-dialog.c | 14 ++++++++++++++ 5 files changed, 100 insertions(+), 27 deletions(-)
commit 8132d51b29d66f062715672f027b24740f380756 Author: Michael Natterer <mitch@gimp.org> Date: Wed Aug 24 18:27:49 2016 +0200 Bug 599573 - Remember dialog defaults between Gimp sessions Remember the "New Channel" dialog settings in GimpDialogConfig. app/actions/channels-commands.c | 88 ++++++++++++++++++++++++++++++--------------------------- app/config/gimpdialogconfig.c | 50 ++++++++++++++++++++++++++++++-- app/config/gimpdialogconfig.h | 3 ++ app/config/gimprc-blurbs.h | 6 ++++ app/dialogs/preferences-dialog.c | 44 +++++++++++++++++++++++------ 5 files changed, 139 insertions(+), 52 deletions(-)
This implments this bug's original request: commit dfa390fd957d1a465aa3d7d1317ea2804cfc037f Author: Michael Natterer <mitch@gimp.org> Date: Fri Aug 26 15:43:25 2016 +0200 Bug 599573 - Remember dialog defaults between Gimp sessions Remember the "Feather Selection", "Grow Selection", "Shrink Selection" and "Border Selection" dialog settings in GimpDialogConfig. app/actions/select-commands.c | 178 ++++++++++++++++++++++++++++++++------------------------ app/config/gimpdialogconfig.c | 113 ++++++++++++++++++++++++++++++++++- app/config/gimpdialogconfig.h | 11 ++++ app/config/gimprc-blurbs.h | 23 ++++++++ app/dialogs/preferences-dialog.c | 48 +++++++++++++++ 5 files changed, 296 insertions(+), 77 deletions(-)
The fill and stroke dialogs: commit 20a32d970d80d7d7c0e3afb1119c1053a510eb1e Author: Michael Natterer <mitch@gimp.org> Date: Wed Sep 14 01:27:42 2016 +0200 Bug 599573 - Remember dialog defaults between Gimp sessions Add GimpFillOptions and GimpStrokeOptions to GimpDialogConfig and use them in the Fill/Stroke Selection/Path dialogs and for the "with last values" commands. Add GUI for them to Preferences -> Dialog Defaults. This requires most of the stuff in my last few commits, and some more changes: GimpFillOptions is a GimpContext which has all sorts of connections to everything, including a Gimp pointer. Hack around in GimpDialogConfig to add a Gimp property, and add "gimp" parameters to quite some GimpRC functions. Treat the Gimp* as a GObject* in all public API because core/ stuff is not known in config/. app/actions/select-commands.c | 45 +++++-------- app/actions/vectors-commands.c | 49 +++++---------- app/app.c | 3 +- app/config/gimpconfig-dump.c | 9 ++- app/config/gimpconfig-dump.h | 3 +- app/config/gimpdialogconfig.c | 167 +++++++++++++++++++++++++++++++++++++++++++++---- app/config/gimpdialogconfig.h | 10 +++ app/config/gimprc-blurbs.h | 6 ++ app/config/gimprc.c | 34 ++++++++-- app/config/gimprc.h | 3 +- app/core/gimp-user-install.c | 8 ++- app/core/gimp-user-install.h | 3 +- app/core/gimp.c | 3 +- app/dialogs/fill-dialog.c | 42 +++++-------- app/dialogs/preferences-dialog.c | 19 ++++++ app/dialogs/stroke-dialog.c | 34 ++++------ app/main.c | 2 +- 17 files changed, 302 insertions(+), 138 deletions(-)
Merge visible layers: commit 905dec866e55da45c45090890716b7be41c17aa6 Author: Michael Natterer <mitch@gimp.org> Date: Sat Sep 24 12:33:42 2016 +0200 Bug 599573 - Remember dialog defaults between Gimp sessions Remember the "Merge Visible Layers" dialog settings in GimpDialogConfig. app/actions/image-commands.c | 35 +++++++++++++++++--------------- app/config/gimpdialogconfig.c | 46 +++++++++++++++++++++++++++++++++++++++++++ app/config/gimpdialogconfig.h | 4 ++++ app/config/gimprc-blurbs.h | 9 +++++++++ 4 files changed, 78 insertions(+), 16 deletions(-)
Convert to Color Profile: commit 3c7fcf4c58010120cd8931f3224a9583c88979bf Author: Michael Natterer <mitch@gimp.org> Date: Sat Sep 24 22:54:42 2016 +0200 Bug 599573 - Remember dialog defaults between Gimp sessions Remember the "Convert to Color Profile" dialog's "intent" and "black point compensation" in GimpDialogConfig. app/config/gimpdialogconfig.c | 33 ++++++++++++++++++++++++++++ app/config/gimpdialogconfig.h | 45 ++++++++++++++++++++------------------ app/config/gimprc-blurbs.h | 7 ++++++ app/dialogs/color-profile-dialog.c | 36 ++++++++++++++---------------- 4 files changed, 80 insertions(+), 41 deletions(-)
Forgot to add the last two to prefs: commit 8ab530ffc060b0079174db8dd8bb6346a94af5f1 Author: Michael Natterer <mitch@gimp.org> Date: Sun Sep 25 00:33:58 2016 +0200 Bug 599573 - Remember dialog defaults between Gimp sessions Forgot to add the "merge visible layers" and "convert to color profile" settings to prefs' "Dialog Defaults" page. app/dialogs/preferences-dialog.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)
The export and import paths dialogs: commit f07b9e17cce78aa0b3c0d7c4e354b679440af616 Author: Michael Natterer <mitch@gimp.org> Date: Mon Sep 26 00:16:47 2016 +0200 Bug 599573 - Remember dialog defaults between Gimp sessions Remember the "Export Paths" and "Import Paths" dialog settings in GimpDialogConfig, including their last used folders. app/actions/vectors-commands.c | 153 +++++++++++++++++++++------------ app/config/gimpdialogconfig.c | 82 ++++++++++++++++++ app/config/gimpdialogconfig.h | 7 ++ app/config/gimprc-blurbs.h | 15 ++++ app/dialogs/preferences-dialog-utils.c | 21 +++++ app/dialogs/preferences-dialog-utils.h | 8 ++ app/dialogs/preferences-dialog.c | 31 +++++++ 7 files changed, 261 insertions(+), 56 deletions(-)
The convert precision dialog: commit 98232c25a5eff91b7348749e753038af07eee8dd Author: Michael Natterer <mitch@gimp.org> Date: Mon Sep 26 17:38:26 2016 +0200 Bug 735895 - Precision Conversion "Dithering" dialog Remember the convert precision dialog's dithering options in GimpDialogConfig. Also addresses bug 599573. app/config/gimpdialogconfig.c | 57 ++++++++++++++++++++++ app/config/gimpdialogconfig.h | 4 ++ app/config/gimppluginconfig.c | 1 + app/config/gimprc-blurbs.h | 9 ++++ app/config/gimprc-serialize.c | 1 + app/config/gimprc.c | 1 + app/dialogs/convert-precision-dialog.c | 87 ++++++++++++++++++---------------- app/dialogs/preferences-dialog.c | 21 ++++++++ 8 files changed, 141 insertions(+), 40 deletions(-)
Indexed color conversion: commit a6b6259b22feca3c637ca25e91a0a27fd9daf1fe Author: Michael Natterer <mitch@gimp.org> Date: Wed Sep 28 00:31:59 2016 +0200 Bug 599573 - Remember dialog defaults between Gimp sessions Remember the 'Indexed Color Conversion' dialog settings in GimpDialogConfig. app/actions/image-commands.c | 67 ++++++++++++++++++------------------- app/config/gimpdialogconfig.c | 95 +++++++++++++++++++++++++++++++++++++++++++++++++++++ app/config/gimpdialogconfig.h | 7 ++++ app/config/gimprc-blurbs.h | 20 ++++++++++- app/dialogs/convert-indexed-dialog.c | 4 +-- app/dialogs/preferences-dialog.c | 30 +++++++++++++++++ 6 files changed, 187 insertions(+), 36 deletions(-)
*** Bug 316335 has been marked as a duplicate of this bug. ***
Hmm, what else? Did I miss any dialogs?
Two more: commit 34eff7322e6ec1b006dd2bee582d1299e0217959 Author: Michael Natterer <mitch@gimp.org> Date: Thu Oct 20 00:30:10 2016 +0200 Bug 599573 - Remember dialog defaults between Gimp sessions Add resize and fill options for the "Layer Boundary Size" and "Canvas Size" dialogs to GimpDialogConfig. app/actions/image-commands.c | 26 +++++++++++++++++------ app/actions/layers-commands.c | 19 +++++++++++++---- app/config/gimpdialogconfig.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ app/config/gimpdialogconfig.h | 6 ++++++ app/config/gimprc-blurbs.h | 17 +++++++++++++-- app/dialogs/preferences-dialog.c | 24 +++++++++++++++++++++ app/dialogs/resize-dialog.c | 50 +++++++++++++++++++++++++++++++++---------- app/dialogs/resize-dialog.h | 5 ++++- 8 files changed, 188 insertions(+), 24 deletions(-)
I think we can close this as FIXED, let's handle new things we find in new bugs...