After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599515 - Fix dvb for DVB API 3.3
Fix dvb for DVB API 3.3
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
0.10.16
Other Linux
: Normal normal
: 0.10.17
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-24 23:14 UTC by Chris Hills
Modified: 2009-11-06 14:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix compile issue with dvb api 3.3 (1.50 KB, patch)
2009-10-24 23:14 UTC, Chris Hills 		needs-work Details | Review
Updated patch based on ToT (1.56 KB, patch)
2009-11-06 14:26 UTC, Chris Hills 		none Details | Review
Updated patch from git (1.87 KB, patch)
2009-11-06 14:33 UTC, Chris Hills 		committed Details | Review

Description Chris Hills 2009-10-24 23:14:50 UTC 
Created attachment 146190 [details] [review]
Patch to fix compile issue with dvb api 3.3

On Linux 2.6.25.3 x86 dvb fails to compile with the following output:-

  CC    gstdvbsrc.o
gstdvbsrc.c: In function ‘gst_dvbsrc_tune’:
gstdvbsrc.c:1308: error: ‘struct dvbfe_params’ has no member named ‘u’
gstdvbsrc.c:1309: error: ‘struct dvbfe_params’ has no member named ‘u’
gstdvbsrc.c:1310: error: ‘struct dvbfe_params’ has no member named ‘u’
gstdvbsrc.c:1315: error: ‘struct dvbfe_params’ has no member named ‘u’

The attached patch fixes the issue.
Comment 1 Sebastian Dröge (slomo) 2009-11-06 13:54:14 UTC 
Review of attachment 146190 [details] [review]:

Please run the source file through gst-indent and only attach git format-patch style patches.

Now for the actual patch, from what I see the delsys variable is only assigned but never used anywhere. Apart from that it looks good
Comment 2 Chris Hills 2009-11-06 14:26:34 UTC 
Created attachment 147100 [details] [review]
Updated patch based on ToT

I have fixed the indentation and updated for the latest commit. Thanks for the review.
Comment 3 Chris Hills 2009-11-06 14:28:42 UTC 
Oops, this is a git diff patch not git format-patch. I shall fix shortly.
Comment 4 Chris Hills 2009-11-06 14:33:19 UTC 
Created attachment 147101 [details] [review]
Updated patch from git
Comment 5 Sebastian Dröge (slomo) 2009-11-06 14:44:57 UTC 
Thanks, pushed :)