After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599386 - Empathy protocol chooser shouldn't cache TpConnectionManagerProtocol
Empathy protocol chooser shouldn't cache TpConnectionManagerProtocol
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.28.x
Other Linux
: Normal critical
: ---
Assigned To: empathy-maint
: 599519 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-10-23 09:20 UTC by Guillaume Desmottes
Modified: 2009-10-26 10:18 UTC
See Also:
GNOME target: 2.28.x
GNOME version: ---

Attachments
trace (5.19 KB, text/plain)
2009-10-23 09:20 UTC, Guillaume Desmottes 		Details

Description Guillaume Desmottes 2009-10-23 09:20:01 UTC 
Created attachment 146086 [details]
trace

The protocol chooser currently cache the TpConnectionManagerProtocol which is
not garanteed to stay valid (see bug #594654 for details, that's the same
issue).

This leads to crash as the one reported on
http://bugs.freedesktop.org/show_bug.cgi?id=24524 or the attached trace.
Comment 1 Guillaume Desmottes 2009-10-23 11:02:52 UTC 
Fixed in gnome-2.28 and master.
Note that distro should upgrade to telepathy-glib 0.8.1 or 0.9.1 to ensure that all crashers related to this issue are fixed.

commit 6931154a620290ec29a50c017d427586fe6d8a3f
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Fri Oct 23 11:17:23 2009 +0100

    empathy-protocol-chooser: don't cache TpConnectionManagerProtocol in the store
    
    TpConnectionManagerProtocol are not garanteed to stay valid so we
    shouldn't cache them in the store. Instead, we cache the protocol name
    and call tp_connection_manager_get_protocol each time we need it.
    This should fix crashers as the ones reported in #599386.


This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 2 Guillaume Desmottes 2009-10-26 10:18:15 UTC 
*** Bug 599519 has been marked as a duplicate of this bug. ***