After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599233 - Dialog of "Save as BMP" ignores changes which are not made with a mouse
Dialog of "Save as BMP" ignores changes which are not made with a mouse
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
2.6.7
Other All
: Normal minor
: 2.6
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2009-10-21 21:05 UTC by alejandro.carranza-angeles
Modified: 2010-03-11 07:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (2.24 KB, patch)
2010-03-10 16:28 UTC, Massimo 		committed Details | Review

Description alejandro.carranza-angeles 2009-10-21 21:05:50 UTC 
When using "Save As" to save an image as BMP, after entering the name of the file, a new Dialog appears showing "Advanced Options".

If these advanced options are modified (The default is 24-bit RGB-888) WITHOUT using a mouse (i.e. using only the TAB and SPACEBAR keys), the changes do not take effect, and the image will be stored as 24-bit RGB-888 (default setting).
Comment 1 Massimo 2010-03-10 16:28:25 UTC 
Created attachment 155760 [details] [review]
Proposed patch

In file 'plug-ins/file-bmp/bmp-write.c' several GtkRadioButtons
are connected to the signal 'pressed' ('GtkButton::pressed' is 
deprecated according to GTK+'s documentation since version 2.8). 

Connecting the corresponding callback to signal 'clicked' instead, 
fixes the problem described here.
Comment 2 Sven Neumann 2010-03-11 07:45:39 UTC 
Thanks. Committed and pushed to both branches:

commit bc02c2f51ee31588ceb8b9d9aebaf1557fe4119c
Author: Massimo Valentini <sixtysix@inwind.it>
Date:   Thu Mar 11 08:42:19 2010 +0100

    Bug 599233 - Dialog of "Save as BMP" ignores changes which are not made with
    
    Connect to GtkButton::clicked instead of GtkButton::pressed.