GNOME Bugzilla – Bug 598111
typing too quickly results in the wrong application being launched
Last modified: 2009-10-13 20:58:01 UTC
it's really nice to be able to launch a terminal by typing <super>term<enter>. gnome-shell does a non-blocking incremental search as i type in each letter of t - e - r - m. the problem is that the <enter> keypress takes effect immediately, so sometimes you get unlucky: "te" matches brasero as the first result "ter" matches "character map" "term" gives gnome-terminal so i i type quickly, sometimes only "te" has been fully incrmentally-searched by the time i press enter and then (even though the text box says "term") i get brasero launched. <enter> should ensure that no search is still in-progress before launching the app.
=> RESOLVED BREAKUSERFINGERS
Created attachment 145369 [details] [review] [search] Finish queued search on Return If we had a pending search processing, finish it when the user activates the entry. This is a small conceptual change; the large diff is simply moving the search implementation (unedited otherwise) from an anonymous inline to a named function so it can be called sanely in _activate.
Created attachment 145371 [details] [review] [search] Finish queued search on Return If we had a pending search processing, finish it when the user activates the entry. This is a small conceptual change; the large diff is simply moving the search implementation (unedited otherwise) from an anonymous inline to a named function so it can be called sanely in _activate.
Review of attachment 145371 [details] [review]: looks good other than: ::: js/ui/dash.js @@ +646,3 @@ this._searchEntry.entry.connect('activate', Lang.bind(this, function (se) { + if (this._searchTimeoutId > 0) { + Mainloop.source_remove(this._searchTiemoutId); typo ("Tiemout")
Attachment 145371 [details] pushed as d1bdd6f - [search] Finish queued search on Return