After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597790 - Traceback while previewing audio stream
Traceback while previewing audio stream
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: General
Git
Other Linux
: Normal normal
: 0.13.4
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-08 11:14 UTC by Tim Waugh
Modified: 2009-10-09 14:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Tim Waugh 2009-10-08 11:14:53 UTC 
Got this traceback while loading a project that had 'Light & Day' by the Polyphonic Spree as one of the audio tracks.

Traceback (most recent call last):

+ Trace 218151

  • File "pitivi/ui/previewer.py", line 445 in _bus_message 
    self._finishWaveform()
  • File "pitivi/ui/previewer.py", line 468 in _finishWaveform 
    self._plotWaveform(cr)
  • File "pitivi/ui/previewer.py", line 497 in _plotWaveform 
    min_ = min(slice)
ValueError: min() arg is an empty sequence 

It's repeatable.  I'm using git at commit 80d99281dec2e79942b6d4b34c907193d42b7d67.
Comment 1 Alessandro Decina 2009-10-08 13:41:14 UTC 
commit 0e6d977a06080b22b0f900211e8263db71686051
Author: Alessandro Decina <alessandro.d@gmail.com>
Date:   Thu Oct 8 15:38:32 2009 +0200

    Fix traceback previewing audio stream. Fixes #597790.
Comment 2 Alessandro Decina 2009-10-08 13:43:28 UTC 
I pushed a fix that should fix the exception. Still it would be great if you could attach the clip which caused it so I can have a closer look.
Comment 3 Tim Waugh 2009-10-08 14:57:22 UTC 
Wish I could but the license prevents me from doing that.

I've taken a closer look myself now I know where to look :-)  and come up with this patch.  There were only 2048 samples to plot, but self.base_width was 2500.  This meant that spp was being calculated as 0.

(Hmm, problems trying to attach it -- I'll try as a separate comment).
Comment 4 Tim Waugh 2009-10-08 15:08:57 UTC 
Strangely, Bugzilla won't let me attach it ("The file you are trying to attach is empty, does not exist, or you don't have permission to read it.") -- same thing with Firefox and links. *shrug*

http://cyberelk.net/tim/data/tmp/pitivi-spp.patch
Comment 5 Alessandro Decina 2009-10-09 14:16:25 UTC 
Thanks for fixing this. I just pushed your patch.