GNOME Bugzilla – Bug 597715
New plugins to add to gst-plugins-bad
Last modified: 2009-10-08 20:57:41 UTC
Created attachment 144979 [details] The handmade patch I start apologizing if i did something wrong, i followed the wiki http://gstreamer.freedesktop.org/wiki/SubmittingPatches to see how i should add new plugins to gstreamer, but the instructions are for cvs and I'm not very used to git yet. What i understood was that i should add my plugins on bad, and them create a patch with the changes on configure.ac and the new files added. Since i was not able to build a patch from git i just created a tar with my modified configure.ac and the new files that i added, on my system (Ubuntu X86 9.04) it configured and compiled with success. What i want to contribute is simply a G723 pay/depayloader and a silence remover. But the plugins are very bad :-), i have some tests and I'm actually using these plugins already but they do not have consistent tests, and they are my first plugins, so they must be filled with ugly and odd things. Neither of them are very complex, but i hope they can be usefull to someone. The G723 payloader only works with 6.3kb/s packets, i do not work with 5.3 kb/s and treat both packets would add complexity and consume some time that i dont have right now. The removesilence plugin will basically filter the stream, he will outputs only voice, fixing the timestamp so long periods of silence wont generate synchronization problems. Gstreamer already has cutter, but he was not much able to do what i wanted, i wanted to get a recorded audio and hear only what people where speaking, not the silences (pretty commom on phone conversations). The only file i changed is configure.ac, all the other files must be only added. I hope that the plugins get added and may help someone, and i hope to contribute more on the future. best regards, Katcipis
The G.723 payloader seems to be derived from the G.729 one, and the copyright attribution has been stripped. Also, maybe having a secondary frame size is common enough to add it to BaseRTPAudio, or maybe not.
Im not very used to doing rtppayloaders, this was my first one, and yes i used the G.729 one and just adapted to G.723, i wanted to add it because i didnt find any pay/depay for G723 and i thought it would be good if someone else that wanted the plugin didnt have to do all the job again. I stripped the copyright attribution because it is no longer a G729 pay/depay ...neither an modification of it, the fact is that the pay/depay for G723 is very similar to G729, so i basically just renamed and changed some sizes, but it is not the same thing anymore and not an extension of g729pay/depay. Of course that if this is a problem i put back the copyright note, if you want i can remove mine and leave just the one that is at G729pay/depay, i have no interest on having copyright with my name, i just wanted to people to know who made it if they wanted to ask questions about it, and i used the G729 as a base because i thought it would be the most similar to G723. About the secondary frame size...as i said...im very newbie...so any help would be welcome...im not very used to the RTP base classes.
Created attachment 145026 [details] [review] New patch with fixed copyright notes
I have fixed the copyright notes, I'm sorry i thought the copyright notes on the source code where not that important...since it is open source everyone has the right to copy, modify and use, i thought it was more to people have an idea of who made it. Since it is important i put back the copyright from G729 in G723 and removed the copyright notes of my source code because i don't want anyone to have problems copying and modifying my source code. I only use G723 6.3kb/s on my work, so i didn't have time to implement 5.3kb/s, but it seems to work well with 6.3kb/s, i thought that gst-plugins-bad was to put plugins that are not completely done (but the functionality that they have already works) or are not completely reliable yet, but people can start to use it and improve it, i decided to share exactly to the next person that needs it can use the one i made and even improve it, but it is true that it was not an amazing job. Maybe on my vacations i can improve the payloader, but right now i just don't have time. best regards, Katcipis
Could you file one bug per element/plugin and attach a plaintext, git format-patch style patch? This single tarball with just the sources makes reviewing and applying harder as it should be :) (Also what Olivier said)
Ok Sebastian, since it helps you guys im going to try, hope i do everything right this time :-)
Guess this is obsolete now that you filed the other bugs (thanks for that!) ...
(In reply to comment #7) > Guess this is obsolete now that you filed the other bugs (thanks for that!) ... Thanks for your pacience too, it is the first time i patch something to an open source project :-).
(In reply to comment #8) > (In reply to comment #7) > > Guess this is obsolete now that you filed the other bugs (thanks for that!) ... > > Thanks for your pacience too, it is the first time i patch something to an open > source project :-). *patience ** sorry for the lousy english :-)