After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597584 - make burning audio cds with brasero work
make burning audio cds with brasero work
Status: RESOLVED FIXED
Product: brasero
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
: 597624 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-10-06 18:05 UTC by Matthias Clasen
Modified: 2009-10-07 20:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.19 KB, patch)
2009-10-06 18:05 UTC, Matthias Clasen
rejected Details | Review
Fix parsing of file paths on the command-line (3.76 KB, patch)
2009-10-07 08:28 UTC, Bastien Nocera
committed Details | Review

Description Matthias Clasen 2009-10-06 18:05:24 UTC
Created attachment 144902 [details] [review]
patch

Here is a patch that makes audio cd burning work somewhat, by actually agreeing
on what to pass on the cmdline between brasero and the plugin.

This still needs to be all redone and moved back into rhythmbox' ui proper. 
All we need is a drive selector and a burn button, no crazy audio project ui.
Comment 1 Bastien Nocera 2009-10-06 20:26:52 UTC
Agreed on the 2nd part, but that's a different problem.

The original problem is that brasero suddenly stopped being able to handle file paths (which aren't URIs). This is a brasero bug, and shouldn't be in rhythmbox.
Comment 2 Bastien Nocera 2009-10-07 00:35:59 UTC
*** Bug 597624 has been marked as a duplicate of this bug. ***
Comment 3 Bastien Nocera 2009-10-07 00:44:40 UTC
Breaks Totem as well, as seen in the dupe.
Comment 4 Bastien Nocera 2009-10-07 08:28:16 UTC
Created attachment 144934 [details] [review]
Fix parsing of file paths on the command-line

Between 2.26.x and 2.28.x, Brasero lost its ability to have
file paths (as opposed to URIs) be used to pass arguments
on the command-line, breaking the existing Totem and Rhythmbox
burn plugins.

Mark the relevant options as being passed filenames and get
the URI/path using GIO in the functions requiring it.
Comment 5 Philippe Rouquier 2009-10-07 20:28:26 UTC
Thanks for the report and the patch. I committed it to both master and gnome-2-28.