GNOME Bugzilla – Bug 597552
Remove evolution-plugin.pc.in
Last modified: 2014-03-03 13:24:31 UTC
Created attachment 144891 [details] [review] patch to add suggested requirements Evolution header files #include headers from libgtkhtml and libebook: mail/em-format-html.h includes gtkhtml/gtkhtml.h and gtkhtml/gtkhtml-embedded.h, composer/e-msg-composer.h includes libebook/e-destination.h. So pkg-config file for Evolution plugins should require libgtkhtml-3.14 and libebook-1.2 so that cflags are propagated properly. Reported for Evolution 2.28.0. Downstream bug: https://bugs.launchpad.net/ubuntu/+source/evolution/+bug/443406
And composer/e-msg-composer.h includes gtkhtml-editor.h.
Created attachment 144894 [details] [review] updated patch
evolution-plugin.pc is not the right place for those dependencies. The new evolution-mail.pc in 2.29 would be a better place. Perhaps that file should be backported to 2.28?
If these dependencies are in a different .pc file, the pkg-config calls in Evolution plugins would need to be changed, wouldn't they? Currently, they use evolution-plugin.pc (at least mail-notification does), and the build fails because gtkhtml's and other headers are not in the -I path.
It would need to use both evolution-plugin.pc and evolution-mail.pc, although evolution-mail.pc alone would probably be enough.
Is the bug still valid ?
I'd prefer just dropping evolution-plugin.pc.
$:andre\> more /usr/lib/pkgconfig/evolution-plugin-3.0.pc Name: evolution-plugin Version: 3.10.4 Requires: camel-1.2 libxml-2.0 libgtkhtml-4.0 gtkhtml-editor-4.0 webkitgtk-3.0 So libgtkhtml is there, libebook is not. mbarnes: Decision, please?
Fixed for Evolution 3.11.91: https://git.gnome.org/browse/evolution/commit/?id=9f7e6ac6e3fcc9e201973fed064c38c9a7addd2f
(In reply to comment #9) > Fixed for Evolution 3.11.91: > https://git.gnome.org/browse/evolution/commit/?id=9f7e6ac6e3fcc9e201973fed064c38c9a7addd2f Nobody provides plugindir=@plugindir@ now :(