After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597086 - gnome-typing-monitor: 5s cool-off period
gnome-typing-monitor: 5s cool-off period
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Typing break
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-02 09:15 UTC by Tim Waugh
Modified: 2009-11-08 10:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
typing-break-postpone-delay.patch (635 bytes, patch)
2009-10-02 09:15 UTC, Tim Waugh
needs-work Details | Review
typing-break-postpone-delay.patch (g_timeout_add_seconds) (826 bytes, patch)
2009-10-22 12:12 UTC, Tim Waugh
committed Details | Review

Description Tim Waugh 2009-10-02 09:15:02 UTC
Created attachment 144575 [details] [review]
typing-break-postpone-delay.patch

When the typing break screen is displayed and break postponements are enabled,
there is a 500ms delay before the 'Postpone' button becomes sensitive.  I
propose increasing that delay to 5000ms (5s).

Version-Release number of selected component (if applicable):
control-center-2.28.0-11.fc12.x86_64

Rationale:
When I'm really focused on something I will click the 'Postpone' button, or
even use the keyboard short-cut Alt-P, so that I can carry on with what I was
doing.  Then later I won't even remember having done it.  This can happen
several times in a row.  I'm sure it happens this way for other people too.

With a 5s delay before a break can be postponed it gives the user time to think
about whether they really need to carry on with what they were doing or if it
can wait after all.

Note that disabling break postponements is quite an inconvenience: there really
are times when it should be possible to postpone a typing break.

Attached is a patch to increase the delay.

Original bug report:
  https://bugzilla.redhat.com/show_bug.cgi?id=526677
Comment 1 Bastien Nocera 2009-10-20 15:36:58 UTC
Review of attachment 144575 [details] [review]:

::: gnome-control-center-2.27.91/typing-break/drw-break-window.c~
@@ +200,3 @@
 		}
 
+		priv->postpone_sensitize_id = g_timeout_add (5000,

Use g_timeout_add_seconds instead.
Comment 2 Tim Waugh 2009-10-22 12:12:58 UTC
Created attachment 146034 [details] [review]
typing-break-postpone-delay.patch (g_timeout_add_seconds)
Comment 3 Jens Granseuer 2009-11-08 10:15:59 UTC
Comment on attachment 146034 [details] [review]
typing-break-postpone-delay.patch (g_timeout_add_seconds)

commit 1fd84f367269fae5b30bad671564aad35656ab6b
Author: Tim Waugh <...>
Date:   Sun Nov 8 11:14:35 2009 +0100