Created attachment 144503 [details] [review]
[places] Fix double spacing between actions and devices

Comment on attachment 144503 [details] [review]
[places] Fix double spacing between actions and devices

>From 6cfe79dbe6dc5f83bb7fdea1a5e5694ad729d3c7 Mon Sep 17 00:00:00 2001
>From: Colin Walters <walters@verbum.org>
>Date: Thu, 1 Oct 2009 08:56:59 -0400
>Subject: [PATCH] [places] Fix double spacing between actions and devices

Looks good to me and works fine (spacing is gone).

>https://bugzilla.gnome.org/show_bug.cgi?id=596991
>---
> js/ui/places.js |   28 +++++++++++++++++++---------
> 1 files changed, 19 insertions(+), 9 deletions(-)
>
>diff --git a/js/ui/places.js b/js/ui/places.js
>index 903cd4e..2d6dbc0 100644
>--- a/js/ui/places.js
>+++ b/js/ui/places.js
>@@ -75,17 +75,29 @@ function Places() {
> 
> Places.prototype = {
>     _init : function() {
>+        // Places is divided semi-arbitrarily into left and right; a grid would
>+        // look better in that there would be an even number of items left+right,
>+        // but it seems like we want some sort of differentiation between actions
>+        // like "Connect to server..." and regular folders

Well sure having an even amount of items left and right, but the current way looks more organized to me, so we should stick with it.

Attachment 144503 [details] pushed as 6baafaa - [places] Fix double spacing between actions and devices