GNOME Bugzilla – Bug 596580
Blank rows in entry autocompletion
Last modified: 2009-10-20 22:51:50 UTC
Compile the attached testcase, press 'a' in the entry, the autocompletion treeview will only show three rows (there's three lines in the model), but only the first one will have something in it. git bisect says the commit that broke this is: commit af73305d37fa185308995b99d8332d9eea2ffe68 Author: Kristian Rietveld <kris@gtk.org> Date: Tue Sep 1 17:51:19 2009 +0200 Marking nodes invisible after pulling in the root level is wrong diff --git a/gtk/gtktreemodelfilter.c b/gtk/gtktreemodelfilter.c index 0d982b2..49020af 100644 --- a/gtk/gtktreemodelfilter.c +++ b/gtk/gtktreemodelfilter.c @@ -1284,13 +1284,6 @@ gtk_tree_model_filter_row_changed (GtkTreeModel *c_model, gtk_tree_model_filter_build_level (filter, NULL, NULL, FALSE); root = FILTER_LEVEL (filter->priv->root); - - if (root) - { - for (i = 0; i < root->array->len; i++) - g_array_index (root->array, FilterElt, i).visible = FALSE; - root->visible_nodes = 0; - } } gtk_tree_model_filter_increment_stamp (filter);
Created attachment 144162 [details] testentrycompletion.c
I am seeing empty completion rows in Midori as well, I think this is the same problem. I reverted the above change locally and completion works normally again.
Thanks for the test case. I looked into this last night already and I am seeing what the problem is, only I need to find out what the right fix was. The commit you pointed out does remove code that was wrong, but does seem to have served a purpose ;) By the way Xan, once this is fixed, I think the reordering crashes will be fixed as well.
*** Bug 596413 has been marked as a duplicate of this bug. ***
Fixed, pushed to master.
*** Bug 599047 has been marked as a duplicate of this bug. ***