Bug 596548 – need to set restart command

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 596548 - need to set restart command


Summary:	need to set restart command


Status:	RESOLVED FIXED

Product:	vino
Classification:	Applications
Component:	Server
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Vino Maintainer(s)
QA Contact:	Vino Maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-09-27 23:13 UTC by Matthias Clasen
Modified:	2009-10-15 16:34 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
patch (796 bytes, patch) 2009-09-27 23:13 UTC, Matthias Clasen	none	Details \| Review
don't restart me, please (475 bytes, patch) 2009-09-28 00:02 UTC, Matthias Clasen	committed	Details \| Review

Description Matthias Clasen 2009-09-27 23:13:01 UTC

Created attachment 144145 [details] [review]
patch

I'm seeing the following in my syslog

Sep 27 16:44:27 planemask gnome-session[21219]: WARNING: Could not launch 
application '104a117a762e5564a6125407913983770400000015300005.desktop': Unable
to start application: Failed to execute child process "vino-server" (No such
file or 
directory)

This is because vino does not set an explict restart command, and then
EggSMClient defaults to just use g_get_prgname() for the command:

Exec=vino-server --sm-client-id 102a73c85315f3112125409162166269700000256550005

This doesn't work because vino-server is in /usr/libexec, which is not in PATH.

The attached patch calls egg_sm_client_set_restart_command, which fixes this.
To make the patch totally correct, you probably want to look at $libexec_dir or
something like that.

Comment 1 Matthias Clasen 2009-09-27 23:43:12 UTC

Crap. Of course, making the restart command work brings back the annoying 'restart in a loop' problem.

Comment 2 Matthias Clasen 2009-09-28 00:01:34 UTC

So, after studying the comments in the 'restart loop' bug again, it appears you just use EggSMClient to catch the quit signal, and don't particularly want to save any state. Therefore, a much simpler and better approach is to just tell EggSMClient that you don't want to be restarted with saved state.

Comment 3 Matthias Clasen 2009-09-28 00:02:24 UTC

Created attachment 144148 [details] [review]
don't restart me, please

Comment 4 Jonh Wendell 2009-10-15 16:34:46 UTC

Thanks, patch committed.