GNOME Bugzilla – Bug 596309
[PATCH] missing icons in the default icon theme
Last modified: 2009-10-10 11:34:14 UTC
Created attachment 143990 [details] icon-theme.patch Balsa is a GTK+ application, but it depends on GNOME icons. However many distributions preconfigure GTK+ to include gnome-icon-theme as a fallback icon theme, it is not correct to depend on it. Attached patch is one of possibilities to fix it, However it is not perfect. Menu icon of "Send and Receive Main" is larger than other icons. Alternative fixes may be: - Require tango-icon-theme - Provide custom fallback icons (possibly with "balsa-" prefix). How to reproduce: 1. Run balsa outside GNOME session in environment where gtkrc does not contain any advanced icon theme. Current benavior: Many icons are dummy "bad icons". Expected behavior: Always show icons.
Thanks for the report, and the suggestion! Yes, Balsa does indeed depend on having the gnome icons to look right, though not in the sense that it won't build and run without them. Perhaps it would make sense to add gnome-icon-theme to the pkg-check section. But would that make building Balsa difficult on any distro? I installed the patch, but I didn't see any difference in the Menu icon of "Send and Receive Main". Does the difference appear only on a non-Gnome setup? Re Tango icons: I installed tango-icon-theme, and a quick look revealed only 9 mail-related icons: actions/mail-forward.png actions/mail-mark-junk.png actions/mail-mark-not-junk.png actions/mail-message-new.png actions/mail-reply-all.png actions/mail-reply-sender.png actions/mail-send-receive.png apps/internet-mail.png status/mail-attachment.png Will the coverage increase as it approaches version 1.0?
GNOME environment runs gnome-settings-daemon. It influences theme of all GTK+ applications. If you start balsa inside GNOME sesison, gnome icons are always searched. To reproduce this bug, you have to run balsa outside gnome-session. Distros must have gnome-icon-theme avaliable anyway, there should not be any problem to require them in pkg check. Tango icons: Well, tango index.theme contains: "Inherits=gnome,crystalsvg". It means, that it inherits all GNOME icons.
Is this the same issue as in bug #562752? The solution reported there was to specify gtk-icon-theme-name as "gnome", rather than gtk-fallback-icon-theme. Would your patch solve that problem?
Patch pushed to master--thanks! Resolving as fixed...
*** Bug 562752 has been marked as a duplicate of this bug. ***
Note to comment 3: Setting gtk-icon-theme-name to "gnome" would hadcode gnome icon theme as the default, independently on icon theme selection in user preferences. On opposite, the gtk-fallback-icon-theme means icon to use, if theme does not provide better one. It's typically empty or predefined by distros to "gnome".