After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596305 - call weak-unref on client->sessions from finalize
call weak-unref on client->sessions from finalize
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-25 13:10 UTC by Luca Ognibene
Modified: 2010-02-09 10:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
call weak_unref in _finalize on all client's sessions (732 bytes, patch)
2009-09-25 13:10 UTC, Luca Ognibene 		committed Details | Review

Description Luca Ognibene 2009-09-25 13:10:27 UTC 
Created attachment 143988 [details] [review]
call weak_unref in _finalize on all client's sessions

If client_finalize is called (for example a client has disconnected w/o calling
TEARDOWN) and later you call gst_rtsp_session_pool_cleanup gst-rtsp-server will
segfault because in _finalize the weak ref on the session is not removed.
Comment 1 Sebastian Pölsterl 2009-10-11 12:00:48 UTC 
Just ran into the same problem. Your patch works fine.
Comment 2 Sebastian Pölsterl 2009-11-03 15:30:03 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 3 Luca Ognibene 2009-11-04 08:12:05 UTC 
Mmmm.. may i ask where have you committed it? i don't see any change here:
http://cgit.freedesktop.org/gstreamer/gst-rtsp-server/
Can you point me to the commit? Thank you!
Comment 4 Luca Ognibene 2009-11-04 08:50:36 UTC 
Ooops sorry, i've seen it now :)