After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596102 - Add shellDBus.js which implements Eval(str) and an Overview property
Add shellDBus.js which implements Eval(str) and an Overview property
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-09-23 18:31 UTC by Colin Walters
Modified: 2009-09-23 20:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add shellDBus.js which implements Eval(str) and an Overview property (3.43 KB, patch)
2009-09-23 18:31 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2009-09-23 18:31:45 UTC 
For various reasons I'd like a method which allows evaluation; say
log in from another machine and run "gnome-shell --repl" or something.

Also as a possible solution for the screensaver X grab issue, add
a (read/write) property "Overview".
Comment 1 Colin Walters 2009-09-23 18:31:48 UTC 
Created attachment 143820 [details] [review]
Add shellDBus.js which implements Eval(str) and an Overview property
Comment 2 Owen Taylor 2009-09-23 20:03:12 UTC 
Review of attachment 143820 [details] [review]:

Basically looks fine, few comments.

::: js/ui/main.js
@@ +79,3 @@
     wm = new WindowManager.WindowManager();
 
+    ShellDBus.createGnomeShellService();

Isn't our general pattern that singletons are static variables in main.js?

::: /dev/null
@@ +12,3 @@
+    methods: [{ name: "Eval",
+                inSignature: "s",
+                outSignature: "bs"

Probably good to have some sort of rough docs for the interface somewhere in this file

@@ +16,3 @@
+             ],
+    signals: [],
+    properties: [{ name: "Overview",

Should be OverviewActive

@@ +64,3 @@
+                                                 "org.gnome.Shell",
+                                                 "/org/gnome/Shell");
+        proxy.IntrospectRemote(function (result, excp) { log("INTROSPECT: " + result + " " + excp); });

Is this idle some sort of debug leftover? If not, it sure needs a comment.