GNOME Bugzilla – Bug 595996
Fixes for scrolling NbtkBoxLayout
Last modified: 2009-10-01 19:31:16 UTC
Two minor bug fixes related to using NbtkBoxLayout as the child of a NbtkScrollView.
Created attachment 143740 [details] [review] Don't use the default stage when setting up adjustments If the actor isn't in a stage, then setting up the adjustment based on the actor's size (which we can't compute) and the size of the default stage (which isn't relevant), doesn't make sense. Just use arbitrary default values. The adjustments will be updated to reasonable values when first the box is first allocated. It's not entirely clear to me why we ever want to compute the adjustment settings this way; perhaps we should always use default values. http://bugzilla.moblin.org/show_bug.cgi?id=6307
Created attachment 143741 [details] [review] Allocate children as wide as the scrolled area When we are scrolling a vertical box horizontally , children should be allocated horizontally as wide as the full horizontal scrolled area, not just to the size of the "viewport". Similarly for a horizontal box. http://bugzilla.moblin.org/show_bug.cgi?id=6312
Created attachment 144328 [details] [review] Allocate children as wide as the scrolled area When we are scrolling a vertical box horizontally , children should be allocated horizontally as wide as the full horizontal scrolled area, not just to the size of the "viewport". Similarly for a horizontal box. http://bugzilla.moblin.org/show_bug.cgi?id=6312
Created attachment 144329 [details] [review] Don't use the default stage when setting up adjustments If the actor isn't in a stage, then setting up the adjustment based on the actor's size (which we can't compute) and the size of the default stage (which isn't relevant), doesn't make sense. Just use arbitrary default values. The adjustments will be updated to reasonable values when first the box is first allocated. It's not entirely clear to me why we ever want to compute the adjustment settings this way; perhaps we should always use default values. http://bugzilla.moblin.org/show_bug.cgi?id=6307
Review of attachment 144328 [details] [review]: LGTM
Review of attachment 144329 [details] [review]: LGTM
Attachment 144328 [details] pushed as 28dbf7a - Allocate children as wide as the scrolled area Attachment 144329 [details] pushed as d67e54d - Don't use the default stage when setting up adjustments