GNOME Bugzilla – Bug 595988
Extend distcheck for files in Git to all files
Last modified: 2009-10-01 19:26:33 UTC
Instead of just checking that we distribute all Javascript files, check that we distribute everything that is in Git. The toplevel Makefile.am has a variable DIST_EXCLUDE that lists patterns of files that we actually don't want to distribute. Remove several stale C files that we are no longer using.
Created attachment 143724 [details] [review] Extend distcheck for files in Git to all files
Review of attachment 143724 [details] [review]: ::: Makefile.am @@ +17,3 @@ @failed=false; \ + exclude=`(for p in $(DIST_EXCLUDE) ; do echo --exclude=$$p ; done)`; \ + for f in `cd $(srcdir) && git ls-files $$exclude` ; do \ Should probably be surrounded in a "test -d .git" ::: a/src/metacity-symbols.c @@ -8,3 @@ - return NULL; -} - I'd split this into a separate patch, it's not really related to the distchecking.
(In reply to comment #2) > Review of attachment 143724 [details] [review]: > > ::: Makefile.am > @@ +17,3 @@ > @failed=false; \ > + exclude=`(for p in $(DIST_EXCLUDE) ; do echo --exclude=$$p ; done)`; \ > + for f in `cd $(srcdir) && git ls-files $$exclude` ; do \ > > Should probably be surrounded in a "test -d .git" Executive decision: I don't care about distchecking if you aren't working from a Git tree. > ::: a/src/metacity-symbols.c > @@ -8,3 @@ > - return NULL; > -} > - > > I'd split this into a separate patch, it's not really related to the > distchecking. Well, it's related in that once the distcheck hook is there, it no longer distchecks without removing those files. But yeah, it's a bit separate. Split in my local tree now.
Attachment 143724 [details] pushed as b90fc1e - Extend distcheck for files in Git to all files