After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595419 - Monkey-patch in ClutterContainer methods for NbtkBoxLayout
Monkey-patch in ClutterContainer methods for NbtkBoxLayout
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-09-16 23:59 UTC by Owen Taylor
Modified: 2009-09-17 20:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Monkey-patch in ClutterContainer methods for NbtkBoxLayout (2.28 KB, patch)
2009-09-16 23:59 UTC, Owen Taylor
committed Details | Review

Description Owen Taylor 2009-09-16 23:59:37 UTC
Setting options for children added to NbtkBoxLayout is not convenient
since we are missing the varargs methods of clutter_container.

Patch in:

 child_set() - set properties of a child
 add() - add a child and set properties (this is different from
         clutter_container_add()! I think the deviation is
         with avoiding the awkward name add_with_properties()
         which is what might be expected. ClutterContainer
         currently doesn't have a method like this at all.)

The code is written to allow patching into multiple ClutterContainer
classes but for now only NbtkBoxLayout is patched, since it's the only
container we are using where we need to set options as properties.
Comment 1 Owen Taylor 2009-09-16 23:59:39 UTC
Created attachment 143313 [details] [review]
Monkey-patch in ClutterContainer methods for NbtkBoxLayout
Comment 2 Owen Taylor 2009-09-17 20:40:19 UTC
Attachment 143313 [details] pushed as a07af9f - Monkey-patch in ClutterContainer methods for NbtkBoxLayout