After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595326 - Bump libtool to 2.2 and remove dolt
Bump libtool to 2.2 and remove dolt
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2009-09-16 02:48 UTC by H.Habighorst
Modified: 2009-09-23 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Bump libtool to 2.2 - disable dolt (6.71 KB, patch)
2009-09-16 02:48 UTC, H.Habighorst
committed Details | Review
Fixes dolt with libtool 2.2 (917 bytes, patch)
2009-09-16 18:39 UTC, H.Habighorst
rejected Details | Review

Description H.Habighorst 2009-09-16 02:48:30 UTC
Created attachment 143258 [details] [review]
Bump libtool to 2.2 - disable dolt

Hi

This patch bumps libtool to 2.2 - as it is the newest version available and
older version will not be fixed, I think this is a wise step.

To quote from the libtool site:
"... This is the first stable release from the Libtool 2.2 branch. Libtool 2.0
was never released, as by the time 1.9f was released from the stable branch,
the head of the development branch had already become much more stable than the
supposed stable branch!! Compared to the old stable Libtool 1.5.x branch, the
new stable 2.2 branch has been almost entirely rewritten, and has too many
improvements and brand new features to enumerate here. Please see the NEWS file
in the distribution for a comprehensive list of user visible changes. ...

Also ported the macros to the newest version.

While at it, I want to remove dolt support.

Basically my decision is based on the fact that dolt isn't actively developed
and there is no progress in git since 7 months. I don't like the idea of having
a ticking time bomb in the build system - as you never know when something
could break or is broken and no fix would be available.
Comment 1 Matthew Barnes 2009-09-16 17:18:00 UTC
While I'm all in favor of dropping non-standard build tools -- especially unsupported ones -- I believe dolt was added to improve linking performance at build time.  I'd like to see some build time measurements before we do this.
Comment 2 H.Habighorst 2009-09-16 18:39:35 UTC
Created attachment 143292 [details] [review]
Fixes dolt with libtool 2.2

After some investigation, I've found out what causes libtool 2.2 to fail with dolt and AM_SILENT_RULES.

dolt doesn't support the options of libtool...

See http://lists.freedesktop.org/archives/dolt/2008-July/000001.html .

I've ported the patch for our own dolt.m4 (as I don't think that this will be integrated upstream), should be applied to evo/eds.

Like this I'm not really fine with leaving dolt there, but the build breakage I've seen is fixed - it's okay. Should I add a new patch without the dolt removal or would you just take it out while merging?
Comment 3 Matthew Barnes 2009-09-16 21:31:42 UTC
I'd still like to see build time measurements before and after...
Comment 4 H.Habighorst 2009-09-17 12:16:33 UTC
Hi, for the bugs 595393 , 595327 here some measurements.

Details are explained here and specific in bug 595327 :
http://pastebin.ca/1569547

dolt is something like a cache for libtool - thus it can bring performance/time improvements in case that libtool is heavily used.

However, in eds it are around 5 seconds on my system.

The measurements were taken without ccache, after every run it was distcleaned and autom4te.cache was cleaned.
Comment 5 Matthew Barnes 2009-09-23 15:04:34 UTC
First patch committed to master:
http://git.gnome.org/cgit/evolution/commit/?id=ce05a504b7cfc725f17aa71b1b5303a816ddd465

Second patch is obsolete since the first patch removes dolt.m4.