After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595305 - "Previous Conversations" window does not have an exit keybinding or button
"Previous Conversations" window does not have an exit keybinding or button
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Archives
2.27.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-09-15 18:13 UTC by Kris Marsh
Modified: 2010-11-15 12:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (5.97 KB, patch)
2010-11-15 11:54 UTC, Emilio Pozuelo Monfort 		accepted-commit_now Details | Review

Description Kris Marsh 2009-09-15 18:13:48 UTC 
This means that, when using a modal window manager, there is no way to exit the dialog, apart from closing and re-opening Empathy.

Please set up Ctrl-W as the default keybinding for close, and consider adding a close button next to the forward/back buttons.

Version: 2.27.92
Comment 1 Guillaume Desmottes 2009-09-18 17:04:32 UTC 
Agreed; we should add a close button.
Not sure for Ctrl-W thougt, what's the exact policy about this shortcut?
Comment 2 Emilio Pozuelo Monfort 2010-11-15 11:36:08 UTC 
I've added a close button on this branch:

http://git.collabora.co.uk/?p=user/pochu/empathy.git;a=shortlog;h=refs/heads/bug-595305

I could also add a Help button on the left bottom corner (like on the Accounts dialog). I haven't done it yet since I need a new yelp to be able to test it.
Comment 3 Emilio Pozuelo Monfort 2010-11-15 11:54:45 UTC 
Created attachment 174504 [details] [review]
patch
Comment 4 Guillaume Desmottes 2010-11-15 11:56:50 UTC 
Review of attachment 174504 [details] [review]:

Looks good, thanks! Please merge to master and close the bug once it's done.
Comment 5 Emilio Pozuelo Monfort 2010-11-15 12:00:20 UTC 
Thanks! Pushed:

http://git.gnome.org/browse/empathy/commit/?id=a05517d865e823e5bd939ae5efcc497ccadef066
Comment 6 Guillaume Desmottes 2010-11-15 12:01:53 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.