After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594797 - duplicated id in stickynotes.ui makes it crash
duplicated id in stickynotes.ui makes it crash
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: stickynotes
git master
Other Linux
: Normal critical
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
: 609124 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-09-10 19:42 UTC by Frederic Peters
Modified: 2011-06-17 20:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that fixes the issue. (880 bytes, patch)
2009-10-07 12:51 UTC, Michal Pryc 		none Details | Review

Description Frederic Peters 2009-09-10 19:42:08 UTC 
stickynotes.ui has some duplicated id attributes in its elements (namely font_label, color_label, font_color and font_color_label).

Therefore the .ui file will not be loaded with newer GTK+ and sticky notes will crash (for example it happens when adding a note).

It's quite easy to fix for *label, as they can just be renamed, but font_color is another matter.  I didn't investigate further.
Comment 1 Callum McKenzie 2009-09-12 02:58:55 UTC 
This is now fixed in master. Not completely trivial to fix since the *_label ids were being used to determine sensitivity. I haven't tested it with a newer GTK+ (so no crash) but older GTK+ give strange sensitivity issues without this fix so I'm fairly confident.
Comment 2 Callum McKenzie 2009-09-12 04:24:26 UTC 
*** Bug 594943 has been marked as a duplicate of this bug. ***
Comment 3 Pedro Villavicencio 2009-10-01 13:36:49 UTC 
on the Ubuntu report we're still getting the same crash with gnome-applets 2.28.0, several users confirmed the issue with that version, do you need an extra backtrace? Thanks!.
Comment 4 Michal Pryc 2009-10-07 12:51:41 UTC 
Created attachment 144952 [details] [review]
Patch that fixes the issue.
Comment 5 Michal Pryc 2009-10-07 12:51:48 UTC 
This is not fixed yet.
I can duplicate this bug on OpenSolaris build 124 with GNOME 2.28 packages as well the code from the head.

There are two duplications more:
 - vbox1
 - label1

Please find attached diff to fix this problem.
Comment 6 Callum McKenzie 2009-10-07 18:44:13 UTC 
Thanks for the patch. I hadn't been able to reproduce the crash on my systems, so fixing it was getting difficult.

Patch applied to master and gnome-2-28.
Comment 7 Enrico Minack 2011-06-17 20:09:11 UTC 
*** Bug 609124 has been marked as a duplicate of this bug. ***