After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594717 - segfault during migration
segfault during migration
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 594740 595399 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-09-10 08:23 UTC by Nguyen Thai Ngoc Duy
Modified: 2009-09-17 07:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that works for me (827 bytes, patch)
2009-09-10 08:24 UTC, Nguyen Thai Ngoc Duy
none Details | Review
gecko-passwords.txt (3.87 KB, text/plain)
2009-09-10 09:09 UTC, Nguyen Thai Ngoc Duy
  Details

Description Nguyen Thai Ngoc Duy 2009-09-10 08:23:11 UTC
I got a segfault when I first ran webkit port. Probably due to out of array access
Comment 1 Nguyen Thai Ngoc Duy 2009-09-10 08:24:47 UTC
Created attachment 142857 [details] [review]
Patch that works for me
Comment 2 Xan Lopez 2009-09-10 08:39:02 UTC
Mmm, would you mind telling me how is your passwords file structured? You have no passwords?
Comment 3 Nguyen Thai Ngoc Duy 2009-09-10 08:50:44 UTC
I have a few. There is one entry in with blank username (host www.google.com) though (don't know how that happened)
Comment 4 Xan Lopez 2009-09-10 08:56:29 UTC
(In reply to comment #3)
> I have a few. There is one entry in with blank username (host www.google.com)
> though (don't know how that happened)

But is the file correctly formed otherwise? There should be a dot at the end of every chunk of URLs/login/passwords. Because it really seems that this is not the case here.
Comment 5 Xan Lopez 2009-09-10 09:01:12 UTC
And anyway, it would be good to know in which line did it crash exactly :)
Comment 6 Nguyen Thai Ngoc Duy 2009-09-10 09:09:11 UTC
Created attachment 142860 [details]
gecko-passwords.txt
Comment 7 Nguyen Thai Ngoc Duy 2009-09-10 09:15:31 UTC
(In reply to comment #5)
> And anyway, it would be good to know in which line did it crash exactly :)

Line 186 ephy-profile-migration.c

while (lines[end] && !g_str_equal (lines[end], "."))
Comment 8 Xan Lopez 2009-09-10 09:57:37 UTC
Thanks, I have fixed this differenly in master now, but the code was indeed broken :)
Comment 9 Xan Lopez 2009-09-10 13:03:48 UTC
*** Bug 594740 has been marked as a duplicate of this bug. ***
Comment 10 Xan Lopez 2009-09-17 07:08:41 UTC
*** Bug 595399 has been marked as a duplicate of this bug. ***