GNOME Bugzilla – Bug 594274
images look bad after upgrading to v0.6
Last modified: 2009-09-15 16:59:39 UTC
After upgrading to f-spot 0.6.1.1 from 0.5.0.3, my photos look bad. Or at least different, and I feel that the previous rendering looked better. I confirmed that it's definitely a f-spot change causing this (as opposed to a change in another system component) by then doing a downgrade-upgrade cycle without changing any other packages. I also worked with clean databases both times. I took some screenshots along the way. This is probably due to the new viewer in v0.6.
Created attachment 142568 [details] fspot-0.5 rendering of part of a photo this one looks nice and smooth
Created attachment 142569 [details] f-spot 0.6 rendering of the same Look at the edges "Nepalica" text. They are clearly more jagged here. Also the "Bhaktapur" text looks less solid. Full-res original photo is too large to attach but can be found here: http://dev.gentoo.org/~dsd/20090905/dsc03056-1.jpg
Created attachment 142593 [details] [review] solution The problem was that PaintRectangle() was always being called with "Nearest" interpolation, regardless of what the ImageView object had been configured with (defaulting to Bilinear). The code/comments in this area are a little confusing. It looks like there were once some plans to make non-nearest interpolation rendering asynchronous, so I left a comment in to that effect. I'm not convinced images look as good as they used to in f-spot 0.5, but this is a big improvement!
that's exactly the thing I suspected, I inverted the 2 interp mode. not sure if I want to paint async, this was more a indication for me to try it on, as the previous code was doing it. commit e0034910400e8d538ca1508cb719d65e8ebe016e Author: Stephane Delcroix <stephane@delcroix.org> Date: Wed Sep 9 16:50:14 2009 +0200 respect the Interpolation mode on drawing this fixes bgo594274. original patch and debug by Daniel Drake