After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594125 - [annotation] Should support /* <private> */ comments
[annotation] Should support /* <private> */ comments
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
: 590274 (view as bug list)
Depends on:
Blocks: 559704 592826
 
 
Reported: 2009-09-04 11:32 UTC by Sebastian Dröge (slomo)
Modified: 2015-02-07 17:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[scanner] Support private/public directives (10.23 KB, patch)
2010-09-20 22:42 UTC, Johan (not receiving bugmail) Dahlin
committed Details | Review

Description Sebastian Dröge (slomo) 2009-09-04 11:32:16 UTC
Hi,
it'd be nice if gobject-introspection would support accessibility attributes for fields, methods, properties and everything else where it makes sense.

For example things like g_object_class_install_property() should really be protected, padding fields of instance/class structs should be private, GObject's refcount/qdata fields should be private, ....

In some cases (for the struct fields) there are comments above the fields like in the case of GObject:
struct _GObject {
  GTypeInstance  g_type_instance;

  /*< private >*/
  volatile guint ref_count;
  GData         *qdata;
};

By default gobject-introspection should assume public accessibility, this should be possible to override somehow and it should parse /* < private > */ comments.


Having this in the introspection data is very useful for languages that know these concepts and to hide private fields.
Comment 1 Johan (not receiving bugmail) Dahlin 2010-09-06 16:50:06 UTC
*** Bug 590274 has been marked as a duplicate of this bug. ***
Comment 2 Johan (not receiving bugmail) Dahlin 2010-09-20 22:42:13 UTC
The following fix has been pushed:
8398ce7 [scanner] Support private/public directives
Comment 3 Johan (not receiving bugmail) Dahlin 2010-09-20 22:42:26 UTC
Created attachment 170724 [details] [review]
[scanner] Support private/public directives

Fixes
Comment 4 André Klapper 2015-02-07 17:03:38 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]