After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593962 - Bad string concatenation in gettext call (mainwindow.py)
Bad string concatenation in gettext call (mainwindow.py)
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: General
Git
Other Linux
: Normal normal
: 0.13.4
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-02 20:19 UTC by Claude Paroz
Modified: 2009-11-27 07:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix string concatenation (840 bytes, patch)
2009-09-02 20:25 UTC, Claude Paroz 		committed Details | Review

Description Claude Paroz 2009-09-02 20:19:12 UTC 
You cannot concatenate string with the '+' operator inside a gettext call, because xgettext won't properly extract the string.
I can understand you want to be pep-8 compatible, but please, let strings get over the 80 caracters per line limit when it makes sense.

-        text = _("The following file has moved," +
-            " please tell PiTiVi where to find it.") + "\n\n" + \

+        text = _("The following file has moved, please tell PiTiVi where to find it.") + \
+            "\n\n" + \
Comment 1 Claude Paroz 2009-09-02 20:25:27 UTC 
Created attachment 142351 [details] [review]
Fix string concatenation

In the patch, I also removed the bold markup from the translatable part of the "Duration" string, as it is better i18n practice.
Comment 2 Edward Hervey 2009-11-27 07:23:46 UTC 
commit 015d05908fce6e67e1f4d9292c34b20ce74c01ab
Author: Claude Paroz <claude@2xlibre.net>
Date:   Fri Nov 27 08:21:42 2009 +0100

    mainwindow.py Fix string concatenation. Fixes #593962