After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593933 - Get rid of HAL
Get rid of HAL
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: general
SVN TRUNK
Other All
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks: 593938
 
 
Reported: 2009-09-02 16:08 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-05-06 14:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make HAL support optional (3.33 KB, patch)
2009-09-03 03:36 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
what i've put into git master (9.50 KB, patch)
2009-09-03 09:03 UTC, Richard Hughes
none Details | Review

Description Javier Jardón (IRC: jjardon) 2009-09-02 16:08:22 UTC
Hal is deprecated, see http://www.freedesktop.org/wiki/Software/hal

g-p-m uses DeviceKit-power now, but backlight handling still require hal when the backlight is not a xrandr device.

All the X drivers need to support XBACKLIGHT before we can turn it off completely. Intel do, nouveau sortof does, so we could disable HAL in g-p-m using a #ifdef if we're sure the drivers support backlight
Comment 1 Javier Jardón (IRC: jjardon) 2009-09-03 03:36:26 UTC
Created attachment 142374 [details] [review]
Make HAL support optional

Added new autogen.sh option: --enable-hal=[yes|no|auto]
In auto mode It adds HAL support only if HAL development packages are installed.
By default HAL support is enabled.

This is one of my first autotools patches, so comments/corrections are more than welcome ;)

Regards
Comment 2 Richard Hughes 2009-09-03 09:03:41 UTC
Created attachment 142387 [details] [review]
what i've put into git master

I've changed your patch slightly, and added all the defines to the Makefiles and in the source. I've included it here for reference. Thanks!
Comment 3 Javier Jardón (IRC: jjardon) 2009-09-03 13:07:17 UTC
Reopened until the code is completely removed
Comment 4 André Klapper 2010-02-19 20:05:58 UTC
Javier / Richard: What *exactly* is still needed in this report to keep it opened?
Comment 5 Richard Hughes 2010-02-22 10:22:24 UTC
All the major display drivers need XRANDR brightness support. Intel, nouveau and radeon should all work okay now, but there are a significant number of users of other cards that rely on HAL.
Comment 6 Benedict Stein 2010-02-22 15:53:18 UTC
What about most Nvidia users, which intend to use the proprietary driver cause of it's 3d support.
Comment 7 Richard Hughes 2010-05-06 14:28:41 UTC
commit 02f23be68cac1e5a01dddde152b6dd8de8c3e71a
Author: Richard Hughes <richard@hughsie.com>
Date:   Thu Apr 29 14:47:26 2010 +0100

    Remove the use of HAL from gnome-power-manager.
    
    Using HAL as a fallback has gone on long enough.
    People just need to be using a sane x drivers now