After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593902 - Warning on DBus class being internal
Warning on DBus class being internal
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: D-Bus
unspecified
Other All
: Low minor
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-02 11:14 UTC by Zeeshan Ali
Modified: 2018-02-13 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't warn about unused internal methods which are meant to be visible on DBus (1.15 KB, patch)
2018-02-13 09:40 UTC, Rico Tzschichholz 		committed Details | Review

Description Zeeshan Ali 2009-09-02 11:14:25 UTC 
If I mark a class implementing a D-Bus service, "internal" I get warning from valac for each of it's public methods to be unused. E.g

[DBus (name = "org.gnome.Rygel")]
public class Rygel.DBusService : Object {
...
    public void Shutdown () {
        this.main.exit (0);
    }
}

valac gives me this warning:


rygel-dbus-service.vala:52.5-52.24: warning: method `Rygel.DBusService.Shutdown' never used
    public void Shutdown () {
    ^^^^^^^^^^^^^^^^^^^^
Comment 1 Felipe Besoaín Pino 2010-09-27 14:24:13 UTC 
This bug was reported against a version which is not supported any more. Developers are no longer working on this version so there will not be any bug fixes for it.
Can you please check again if the issue you reported here still happens in a recent version of GNOME and update this report by adding a comment and adjusting the 'Version' field?

Again thank you for reporting this and sorry that it could not be fixed for the version you originally used here.

Without feedback this report will be closed as INCOMPLETE after 6 weeks.
Comment 2 André Klapper 2010-09-27 14:37:54 UTC 
Felipe: Such comments don't make much sense if reporter == developer.
Comment 3 zarevucky.jiri 2010-09-27 15:16:22 UTC 
Actually, they do. One might report the issue and forget about it.
As for this bug, I confirm it's still present in latest version.
Comment 4 Felipe Besoaín Pino 2010-09-27 18:06:14 UTC 
changing the status to NEW, since the bug still and is confirmed.
thanks Jiří.
Comment 5 Michael 'Mickey' Lauer 2018-02-13 08:00:00 UTC 
Confirming it's still an issue, but lowering the priority.
Comment 6 Rico Tzschichholz 2018-02-13 09:40:15 UTC 
Created attachment 368302 [details] [review]
Don't warn about unused internal methods which are meant to be visible on DBus
Comment 7 Michael 'Mickey' Lauer 2018-02-13 09:44:35 UTC 
Review of attachment 368302 [details] [review]:

Works as advertised, thanks.
Comment 8 Rico Tzschichholz 2018-02-13 11:44:24 UTC 
Attachment 368302 [details] pushed as f15f9f8 - Don't warn about unused internal methods which are meant to be visible on DBus